From patchwork Thu Apr 11 02:36:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov via arch-projects X-Patchwork-Id: 1067 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 968FDD2D2BD4 for ; Thu, 11 Apr 2019 02:36:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] [127.0.0.10] Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Thu, 11 Apr 2019 02:36:57 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 4FB7811E2741ED; Thu, 11 Apr 2019 02:36:56 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Thu, 11 Apr 2019 02:36:56 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 137552C5EE; Thu, 11 Apr 2019 02:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1554950216; bh=NnNBfCryMwAolfPAVWl9MyMdKdCozLcEcuMHGBSVAPo=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc; b=PRFgZe5ywvNAFjsMtygnLlKAsCY3eBlWU8bGK596k6pL2xh+CoVZLnVBHGFnfB/1f RQ8ZOQFk3vc+wM8QgRomWLrFpGe3qnv5lWN6HZ2yfCl+JOF+cDVPcxw4D16XdVTH2a G0K2QtHakELEVvjSI6Ug9SUPHKspecEttG2SgFUhy5vWFlgap/6GEWZrmhyB88llYa yw0duK3AP+Y/f3xSQhSJTayFRhRgpJnlmKzaO8nClda/LJDLq3Ccg0u+AqUu2prERb D6MYMaENvlWjgtYF188xe0VPdE252eqsLFg99JTPk3L8U5NVVwZAHI7iaRpyUN62Je PnTFTmUKG9QS6oC1beeahvxkOATwKQjpYKg7Li0D6nFr+cHseeZEJEuwLnFHOS9pKd PpWhTNIlPSTwSDJtbC34lGKkU5ta72L3SCJujEKETBQLNHOqAZlej3wTN+PqNxVS9i io6sn+s+5g8ckpCHXlxZueFVGPkrmUQO0d97bYh8RfhsYMMhX5seFp+2L+eHfR5MGG Tf9Vq16N9lJHF5J6C75H2+X5/xZvCqWu9yLpU9PLzZrVbaFhEQ9VEAXJUY2JXtu3Gj U5viCC7r2nJkJdLjNsunF8IIcv6ZUrg0r89IwZapD3vTincU2jcrku3fCnCZLaEee2 reBEjl/FGVh5ZOF8Q9h2HNGQ= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 3D30C2C5ED for ; Thu, 11 Apr 2019 02:36:52 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Thu, 11 Apr 2019 02:36:52 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 1103511E2741E9; Thu, 11 Apr 2019 02:36:43 +0000 (UTC) Received: from localhost.localdomain (ool-3f8fe1f1.dyn.optonline.net [63.143.225.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id 875DD11E2741E8; Thu, 11 Apr 2019 02:36:42 +0000 (UTC) To: arch-projects@archlinux.org Date: Wed, 10 Apr 2019 22:36:32 -0400 Message-Id: <20190411023632.29921-1-eschwartz@archlinux.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [arch-projects] [namcap] [PATCH] remove pointless mkdir -p in parsepkgbuild X-BeenThere: arch-projects@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Arch Linux projects development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Schwartz via arch-projects Reply-To: Arch Linux projects development discussion Cc: Eli Schwartz Errors-To: arch-projects-bounces@archlinux.org Sender: "arch-projects" As far as I can tell, this was never used. In commit 9b56647abc8dc33bf138d4b260b103c8d9265b7d the parsepkgbuild script was switched from defining a PATH as a directory in /tmp, to actually passing in a PATH=/dummy to `env -i`... which makes sense as the defined PATH did not used to be used. However, even before that, it's not safe to use mkdir -p in order to define a restricted shell without access to the PATH, as it's not guaranteed to be owned by the creator. In any event, the time for mkdir -p is long past. Signed-off-by: Eli Schwartz --- parsepkgbuild | 2 -- 1 file changed, 2 deletions(-) diff --git a/parsepkgbuild b/parsepkgbuild index 009e89e..bedb0de 100755 --- a/parsepkgbuild +++ b/parsepkgbuild @@ -1,7 +1,5 @@ #!/bin/bash -mkdir -p /tmp/parsepkgbuild - source /etc/makepkg.conf PARSE_PKGBUILD_PATH=${PARSE_PKGBUILD_PATH:-/usr/share/namcap}