From patchwork Tue Mar 12 17:01:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Schwartz X-Patchwork-Id: 1039 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id D4D31C70D6E0 for ; Tue, 12 Mar 2019 17:01:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:44 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id A9FDB11331AC0C; Tue, 12 Mar 2019 17:01:37 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Tue, 12 Mar 2019 17:01:36 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 60D712BF74; Tue, 12 Mar 2019 17:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1552410094; bh=wRRnmN1Hnz3dGbzV58UFkdApiYiitmMaebK546iai34=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Reply-To; b=pScOCUVwZ+y2GS3gZUEa5HYaaSFnb3ph5J8QQRypqfJkHEILG2B1ZcdnzfK2Xsbqd VsYTBAVTEEM/mt0KuiyOUPvX+BhEK0sD+X1kykbbrk4B1Fp+y/HM9L+Sr+RD5uunJm RGv4l+2v2ElYq6vRnsnFWiV1nSyM96v9KBBwUPxN89jP+nMh3z0uKhC49/vqUz5nRA ZGMZtm+2s/LLCxafFW7vVdVuACGDwmBr9U6e1ID9CbWQ45Xq13LqLVvmBdH0/BMdP8 gteXGHAu+e4IJbkcAVAiFtF/NhlpGQH13y0FCO7FOwstGXOZdQp5JSIDT76cxdOy70 gakUvUDTJI9Sm9Q5ZD0HdMkNwUnECdRFpL3nFQivEI5BmYvdhWMTlD9QuTUn1oNp6H K0OZbqtvy+SLxhO9u35517vQHkxXRoIGPJlTlLLnS1p5VcvjqD5/eota3R6T/VNIQV fCUIJbK9lrlWZvGXyhtxILrB8j45ZfnNwRGUEvYCiV7GKNIJTqToaLqASghqNfsVP3 CFDjtsXaXNEqE7H4+hdiLIFpKIv/lki+99dh+7fdvuHKXcSYpMjXYpEfMdQzkaF07n +uvxLesY3ED5Y+oRjB0CIvwer7QcVucAwXnAPtG06mwdXdnfyD4iGDjLZRGbQH+Z+y XFlM5hDXrma1T3E31R4fNwRI= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 63F262BF3B for ; Tue, 12 Mar 2019 17:01:30 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:30 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 14F2F11331ABF4; Tue, 12 Mar 2019 17:01:25 +0000 (UTC) Received: from didactylos.localdomain (unknown [216.97.144.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id 9A4FD11331ABF3; Tue, 12 Mar 2019 17:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=orion; t=1552410084; bh=wRRnmN1Hnz3dGbzV58UFkdApiYiitmMaebK546iai34=; h=From:To:Subject:Date; b=G7M4gs2ykCytuZZ83M4ou7G+wcm5wV2XH+2K62/xUJfmYETZKFOMJR31wQbR96Xaz mgRATk2IjmZQQ+gGSSvUb8kEHwXMpqasPbw9EfNzGhj78fjNLC2UWh4xmiZEIGjv3i hNe6iJWNwn48mR+B+nXR2lsqUy/2dDJkg344OlIU6mmUl7Wry3+JFmidqF6wceks9r 02/q2a3aqgjwxqw4NqfkdGTmaE6WowJDX/MSrt3dQp6PTE/PS8GZuu2IFRgcXOuhdb 7Ve1Kc39CAZ35Wsv4HeOWlEURx+O7gsp9izgkuZjW+2GBmg4KJ9xKbn8wRb1FtSpE2 gjJPhQnXQxYHo6U7l4ZFWg8A/VH6IkOzPhr8MHc4rQcT87Mu29M67VDvaOXfWZVO3w n0QTbwDU51wucgEDLFbx968gg5vj02Xf067zE1ecKrwJv6LzZTU18dPrmI++FUgR5r byE1aWPgI1KWWLzBOm6shUgFd/Y3Sxyop7tphGjv7v9zSiJ9dxdnVxKJWgQOoLZyiG NLFSqX2pDPIywvilrjAlsFLDzl3vMZmqC+xJ83sEDbpGkBnwcxVndE5VhgDbGIxq6k QR1tDHx0E2mHU0KxghRw4nHbewhTKQ3tiK88rfF8X3R2P2gsCfA4ADlbYTDOkVnMNx p4GQjG1OKI7oQnjuGPXnfnFc= From: Eli Schwartz To: pacman-dev@archlinux.org Date: Tue, 12 Mar 2019 13:01:12 -0400 Message-Id: <20190312170114.9291-1-eschwartz@archlinux.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [pacman-dev] [PATCH 1/3] doc: describe when and why the prepare function should be used X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Discussion list for pacman development Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" We don't want people to run architecture/OS/makepkg.conf specific processes during prepare() and in fact it's been observed that makepkg by design doesn't even run prepare_buildenv() for it, so the prohibition against this is now baked into makepkg. Reflect this differentiation in the documentation on just what, exactly, a prepare() function is. Signed-off-by: Eli Schwartz --- This patch coincides with quequotion's clarification of the options=() array, so thanks for inspiring me to write this! I believe that both patches have merit independent of each other. doc/PKGBUILD.5.asciidoc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/PKGBUILD.5.asciidoc b/doc/PKGBUILD.5.asciidoc index e8ce691f..285627ab 100644 --- a/doc/PKGBUILD.5.asciidoc +++ b/doc/PKGBUILD.5.asciidoc @@ -342,9 +342,12 @@ files into the packaging directory, with optional `prepare()`, `build()`, and *prepare() Function*:: An optional `prepare()` function can be specified in which operations to prepare the sources for building, such as patching, are performed. This - function is run after the source extraction and before the `build()` - function. The `prepare()` function is skipped when source extraction - is skipped. + function is run exactly once, after the source extraction and before the + `build()` function. The `prepare()` function is skipped when source + extraction is skipped. No system-specific or build-specific commands should + be run during `prepare()` under any circumstances, as they are meant to run + exclusively during `build()`, and features like `buildflags` or `makeflags` + are expressly not available. *build() Function*:: The optional `build()` function is use to compile and/or adjust the source From patchwork Tue Mar 12 17:01:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Schwartz X-Patchwork-Id: 1038 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 7491CC70D6C1 for ; Tue, 12 Mar 2019 17:01:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:36 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 5949B11331ABFF; Tue, 12 Mar 2019 17:01:34 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [5.9.250.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Tue, 12 Mar 2019 17:01:34 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 346122BF4B; Tue, 12 Mar 2019 17:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1552410094; bh=ehM/wuy7TPirt4Q6GTn0HUPo/rU7ZMJSR6kAJJDwrm4=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To; b=Li05G0mN1Db4UlejZdTL4A33/WSYBQ+Uatx3ywJMHpg4UsYxsmDQuLideNlwm0US3 S6kfBm7PELwc6FPWcpZAbUZMoGeo2rEQeVjZFEJP+6otVp/csISg45GecPOp/kfxuy AAXtFGT1/9mwAap+L9jtpKKPcW1dDO1xIVoPE7bZBxp8KxjhzFfHYFpfdEqV4QFFEj 1RueRNle3UDkNoQJkV0BqNmUyF7Md3ZdQVTgFE1gAo/wyid7ivl47haGGD3uWpjLzh oZRYLwSbQf6JXKOD1gXS1pZxGJyhxUG85ftUFOgunntjwSSv4rv5Sm/iWJKMniWvx1 WUhMJawax1esRaZ8VZ9AjKiYl+AZWFgETC2fuyLEuh8Qju0/o+W33GaP4ArCLwjtac OdyXQN9/x72YlPjyA+sxVGDmwX05WG7+vZWYbn8sqGp1uBZHj1WtVQcxugBudTIuSj klcOJlmYiM5rRWl9qesXIOsBRawD9e8uniGyNzxtN85y9J+n32njKKNdrKrVI1WjLM ezUqoPhG5CJBc7b0/9y4p5RisZSHWNm3JhINAdLYFt2NPZdMFSItYEAbZ6BtWXtFeT M1BrqCSsDO+GlhtQ9Xbc5Ogo/tL+dAkPPjNi47LxkejA6to3GPOmC0qOcySLkX2neX GjAxSv2BKgF5C/n4L6cLJKHs= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id E7CEA2BF4B for ; Tue, 12 Mar 2019 17:01:30 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by luna.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:30 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 9F57111331ABF6; Tue, 12 Mar 2019 17:01:25 +0000 (UTC) Received: from didactylos.localdomain (unknown [216.97.144.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id 310A111331ABF5; Tue, 12 Mar 2019 17:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=orion; t=1552410085; bh=ehM/wuy7TPirt4Q6GTn0HUPo/rU7ZMJSR6kAJJDwrm4=; h=From:To:Subject:Date:In-Reply-To:References; b=jXbwOBXBi4nGpDEAr2BjOHLgn6q4Mt0cKiG/yTteMJ8uc6loMCfKeYhHOwKTt0Ckm JhTKAzZxcEC3SO7qkqbQU5OthgZ887gtbF5MWA7zmnjrDIW4CUoy7azArWK1TyhVP9 BCbmrj8wf+c+cqMU1Kszp/vBNYP7HHIhowLjft4zM4PakAoxUpn7quLrpkmgz22IbC UzJbSUik7EgwqjZLan9FfAB2nGhtmLJQzKoty0Yr4exuj6jXQMzixtYmGSJ9xI+5iD 6cvfj6YTIxwNkMHZZ7SMoP6ykZBZpgyynWRVxJX8FklCQl3RML+54clI8ESqap86ZL 07k3nTO/wSN89RcITQrjW5ykXFGQkZxD2ISlPtJ4Ay4RNmYcDeltuoIBtXi9ui24sz 11OrmSPzUvX/G+H24j3tUPvpPoj2cX/4cPkWi8WqUs62ZZBAaRcSTI1uaOcH6zo2MX RbDAGn1eC3QFrpmrpLTUEegelVZP7Pwn35tMQee43bHt/CSrcj7f1//liMH5xkf4Jd L9NTSzI9j/wzhRUn4qe/TcEx0R9Up6qJHytQvL6vy6+8pLs6KashmkniZGBii+d9kX EIyZLkVoK41nvE77YBIlDcPxMEvzGGoB5wwq+TL+BW6s3YS+MVysnxRX15FHm+jwWp 0mt8MbqarLkVdnYaLsPSNojI= From: Eli Schwartz To: pacman-dev@archlinux.org Date: Tue, 12 Mar 2019 13:01:13 -0400 Message-Id: <20190312170114.9291-2-eschwartz@archlinux.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170114.9291-1-eschwartz@archlinux.org> References: <20190312170114.9291-1-eschwartz@archlinux.org> MIME-Version: 1.0 Subject: [pacman-dev] [PATCH 2/3] doc: generalize description of the bash nature of PKGBUILD functions X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Discussion list for pacman development Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" Currently this is scoped to the build() function, which is simply wrong as it equally applies to any function. Simply moving the paragraphs up to the main manpage section makes this clear. Signed-off-by: Eli Schwartz --- doc/PKGBUILD.5.asciidoc | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/doc/PKGBUILD.5.asciidoc b/doc/PKGBUILD.5.asciidoc index 285627ab..83a61458 100644 --- a/doc/PKGBUILD.5.asciidoc +++ b/doc/PKGBUILD.5.asciidoc @@ -332,6 +332,14 @@ PKGBUILD must contain a `package()` function which installs all the package's files into the packaging directory, with optional `prepare()`, `build()`, and `check()` functions being used to create those files from source. +This is directly sourced and executed by makepkg, so anything that Bash or the +system has available is available for use here. Be sure any exotic commands +used are covered by the `makedepends` array. + +If you create any variables of your own in any of these functions, it is +recommended to use the Bash `local` keyword to scope the variable to inside the +function. + *package() Function*:: The `package()` function is used to install files into the directory that will become the root directory of the built package and is run after all @@ -351,14 +359,7 @@ files into the packaging directory, with optional `prepare()`, `build()`, and *build() Function*:: The optional `build()` function is use to compile and/or adjust the source - files in preparation to be installed by the `package()` function. This is - directly sourced and executed by makepkg, so anything that Bash or the - system has available is available for use here. Be sure any exotic - commands used are covered by the `makedepends` array. -+ -If you create any variables of your own in the `build()` function, it is -recommended to use the Bash `local` keyword to scope the variable to inside -the `build()` function. + files in preparation to be installed by the `package()` function. *check() Function*:: An optional `check()` function can be specified in which a package's From patchwork Tue Mar 12 17:01:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Schwartz X-Patchwork-Id: 1040 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 501C3C70D700 for ; Tue, 12 Mar 2019 17:01:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:46 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 9A40911331AC0D; Tue, 12 Mar 2019 17:01:39 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Tue, 12 Mar 2019 17:01:39 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 89D492BFC9; Tue, 12 Mar 2019 17:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1552410094; bh=5l3fmUdhCroZTV+hnHSnkUmxcvd0vYjWHt8+UAerd88=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To; b=dN4bTr9BVHHZ1ExYrqXVqmR5H2Q0Lo/KncYfTr/x67kbo5qrUsmjb8uEULtsjTJCA fW23L3mr4/Z9qItBNwVh3qP/hFkWZ/ZVc0gFrzY3bjmGtwkWPeQquj1pYGnWoSXgD8 4amO6dGZFHde76qXgAbYEPYlMcaVgT0wIdSBHLfrj0aU3JkLUvLD7tzU/fSLRahxgI pjJaQ7PLIsBxd9mWsSjmoj6HCUowH1crgqWHmtIjwXx1KSkpV+Fe/Q8SzQ9j86QSxb H6VmsY4julOYfzEpJ118tGVgovWtANPx4kbnj8jMAxkiKGhpha2ozbupw2t3Cy344t GwkmrBE5Xq4yz5BCybYThVYMYkYxrGKK1f3DCJilQL1pu++qirIxkuNjfXC3ZJD5rw 7SJ10YrbMYUFQ+KBdROtEg7Cj4BleEGKk05s0ywki1QZEg4emX6SbYzfh1A8dFLIj7 xq5fseAOb/gaU0IHWYHd9ry9bpymPkzTXCVjA8H6zZ9nhxZMcvKTblH7qet3jDuJ/z 9lak28Ju1hmrLBFy5ZVN6YDwrbqjWq3Opn/MsypQbKIY7nClXaJ9v+CgnfCXwd4X/M UiuAhTlAslJwau7a6kct4JfH8+QP/8jpoujbIJX3iCDeN3AV/LryVGR9GnCqVm2QZJ BWUre2CAV70W7QpZFB9QlnTo= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 36B9B2BF60 for ; Tue, 12 Mar 2019 17:01:32 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Tue, 12 Mar 2019 17:01:32 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 4681611331ABF8; Tue, 12 Mar 2019 17:01:26 +0000 (UTC) Received: from didactylos.localdomain (unknown [216.97.144.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id BFB9411331ABF7; Tue, 12 Mar 2019 17:01:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=orion; t=1552410086; bh=5l3fmUdhCroZTV+hnHSnkUmxcvd0vYjWHt8+UAerd88=; h=From:To:Subject:Date:In-Reply-To:References; b=SrmZVCWqnynFQoXwCSLURmae4U+y5fBGnLgGKrg+f1DnKq4WbNR5r1jiNnWVWVeK5 X572xmhEQg4MdKorTPha+zikXW1/KNB9tDJIXxjHVyXMlZF9pKE5i5GuBxFrT0dSy/ WSNRDCrAfCSfWYPYuVFMO10UnrhejGVh4J3hf+gS+I1D6WtcAXaunmceDRv9SBssAe JGPna+6dsUCG7E38ptvTe7ktu9Pwf4ghoHnRN/iZTtt9AnSNzhnvM1hzFWTTG8stYS 2deJQxCuGOVG0t0VZdkqxvNlVl+cbZQ6Ll79EtQzbFtK/Vn82/EnNUvL375n/1tFpD exaU3fEBRCICICmR8SOv7eyqDT8HEn0fkIH2IJ4+KQormd0dkU4v+YiXx3z/IIFAgl /OrWnPFv6SLuzH635pXuPpLXjesF7by2hatVH1dDzHGIz7kMVii3gHs1/sMh8qFE4H bggdOQuBmI9xoJJ9QteinmHNcIRE9gQh5453G/mzol91YP0wChQzNrjS70kYUQvghU h8vIit+QlY7o4XbhPmgeV0uDfGLJ/UEbMfVTBNJBNT+CkKZQZX7tYNvDo6oCy9eLTc QRJX2QMAcFqv0dqCShOu5gy75/Y/ffvGrcjtTGsqq9NtZsy1fGCp58nz0xpOjwkO8W zupD5pxtxXZ8HcgkegtMlwqg= From: Eli Schwartz To: pacman-dev@archlinux.org Date: Tue, 12 Mar 2019 13:01:14 -0400 Message-Id: <20190312170114.9291-3-eschwartz@archlinux.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170114.9291-1-eschwartz@archlinux.org> References: <20190312170114.9291-1-eschwartz@archlinux.org> MIME-Version: 1.0 Subject: [pacman-dev] [PATCH 3/3] doc: elaborate on what a build() function is meant for X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Discussion list for pacman development Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" It is often not obvious to people, that build() can be run multiple times when continuing a build with --noextract. Signed-off-by: Eli Schwartz --- doc/PKGBUILD.5.asciidoc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/PKGBUILD.5.asciidoc b/doc/PKGBUILD.5.asciidoc index 83a61458..6336a5cd 100644 --- a/doc/PKGBUILD.5.asciidoc +++ b/doc/PKGBUILD.5.asciidoc @@ -359,7 +359,11 @@ function. *build() Function*:: The optional `build()` function is use to compile and/or adjust the source - files in preparation to be installed by the `package()` function. + files in preparation to be installed by the `package()` function. All + commands specific to the package creation (but not source code + preparation), before the final installation of files into the packaging + root, should be performed here. The `build()` function is permitted to run + multiple times if `makepkg --noextract` is used. *check() Function*:: An optional `check()` function can be specified in which a package's