From patchwork Sun Jan 27 01:59:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov via arch-projects X-Patchwork-Id: 981 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 3299AAE4E3F7 for ; Sun, 27 Jan 2019 02:00:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-1.081,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Sun, 27 Jan 2019 02:00:20 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id B20EA104DA0717; Sun, 27 Jan 2019 02:00:15 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Sun, 27 Jan 2019 02:00:15 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 873FE25D37; Sun, 27 Jan 2019 02:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1548554415; bh=P2ZVyJ1WMeaRHI3RgceVsVBanG6G+SEof4ZxeqrmgfI=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc; b=Vvt0+zi5GI4SeNaiy+fozgv+6E4iLQWyRH4IGDzEu7o6Zx16WqaLx04U8O4fPhzx5 q89SlUDdqnPXvw4HQOYk6SrSAoCLj4x1oqGnx7NoahNYGYV7JWCjMsazL6Rmkx8DQV ncdkOqAL2cddW/WFJGQNWhvqxLtZ/I6+CYORZ+CmKwKIG3OdTBQ1v8j0AZA5M70Go9 WKvRNEl6zCkbeOXuynk4N70FmU2TkJQeANsF+w+SWxLHJLkqeK1iJdJW/f8KsQXdIO /V/RRjg0es/SokEj3sozZQ8ZeLvagt6n6BADBITUhh3Au/YHhQ8R3izL4D97m27TiA cSyke0s8lJlViE6k0ctD3sEjP/JLLw0crhKvkeZ0LOOGvWbAxcDbWgS5la1cFZS9KY CbjU2OGvGoOpwzxjFxtEkhhtldLmdQc9guebPtBhfJPJ83CfWGFQieBHvGS46gdkrw c6uRjnZSQ7WllGf/wBIHdoQ4f/bTM1MQxzyZieaKb3YDz/mB3oyV5A9Z0oTvPACjWv JMC59jHVXEoy+dhVOjfN22or9aTimauMjJrr+UcS+KnWR3kgSAfgw/AaPyZqlN4+xv GgoiwrTpIodMX5bHwmFd4iRSPpql4jRkQ2ea0zDOFdVtRCK3P15IxTHAskGvL8yMaW rMnPO6JEUdRxIS8L9bDeF+qo= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 5076C25D2D for ; Sun, 27 Jan 2019 02:00:12 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Sun, 27 Jan 2019 02:00:12 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id B33CA104DA0712; Sun, 27 Jan 2019 02:00:05 +0000 (UTC) Received: from didactylos.attlocal.net (unknown [IPv6:2600:1700:57f0:ca20:763a:c795:fcf6:91ea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id 26AF3104DA0711; Sun, 27 Jan 2019 02:00:05 +0000 (UTC) To: arch-projects@archlinux.org Date: Sat, 26 Jan 2019 20:59:51 -0500 Message-Id: <20190127015951.27536-1-eschwartz@archlinux.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [arch-projects] [netctl] [PATCH] Makefile: specify the correct shell to use X-BeenThere: arch-projects@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Arch Linux projects development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Schwartz via arch-projects Reply-To: Arch Linux projects development discussion Cc: Eli Schwartz Errors-To: arch-projects-bounces@archlinux.org Sender: "arch-projects" The Makefile commands in use include bash-specific features like brace expansion, and thus cannot run under the default /bin/sh shell as that may or may not be GNU bash (bash supports brace expansion even in posix mode). Consequently, the Makefile failed to execute correctly when the system /bin/sh was a different sh implementation, such as dash or busybox ash. Fix this by declaring the SHELL which will be used when running all commands. --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 716bb15..60af032 100644 --- a/Makefile +++ b/Makefile @@ -2,6 +2,8 @@ export VERSION = 1.19 PKG_CONFIG ?= pkg-config +SHELL=/bin/bash + sd_var = $(shell $(PKG_CONFIG) --variable=systemd$(1) systemd) systemdsystemconfdir = $(call sd_var,systemconfdir) systemdsystemunitdir = $(call sd_var,systemunitdir) @@ -64,4 +66,3 @@ upload: netctl-$(VERSION).tar.xz clean: $(MAKE) -C docs clean -@rm -vf netctl-*.tar.xz{,.sig} PKGBUILD netctl.install -