From patchwork Thu Jul 21 09:51:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allan McRae X-Patchwork-Id: 2069 Return-Path: Delivered-To: patchwork@archlinux.org Received: from mail.archlinux.org [95.216.189.61] by patchwork.archlinux.org with IMAP (fetchmail-6.4.30) for (single-drop); Thu, 21 Jul 2022 09:52:17 +0000 (UTC) Received: from mail.archlinux.org by mail.archlinux.org with LMTP id wNv1J9Ah2WIcpwwAK+/4rw (envelope-from ) for ; Thu, 21 Jul 2022 09:52:16 +0000 Received: from lists.archlinux.org (lists.archlinux.org [95.217.236.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.archlinux.org (Postfix) with ESMTPS id A93F112518BC; Thu, 21 Jul 2022 09:52:15 +0000 (UTC) Received: from lists.archlinux.org (localhost [IPv6:::1]) by lists.archlinux.org (Postfix) with ESMTP id 7FFDC1214658; Thu, 21 Jul 2022 09:52:15 +0000 (UTC) X-Original-To: pacman-dev@lists.archlinux.org Delivered-To: pacman-dev@lists.archlinux.org Received: from mail.archlinux.org (mail.archlinux.org [IPv6:2a01:4f9:c010:3052::1]) by lists.archlinux.org (Postfix) with ESMTPS id A07EF121464F for ; Thu, 21 Jul 2022 09:52:13 +0000 (UTC) From: Allan McRae DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=archlinux.org; s=dkim-ed25519; t=1658397133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=641DCOG5oP1SHnxRTokzUSxzH3s1Kx0VyISCZgh6heE=; b=zt5vHG8zR3SpSCKqiqSBeiVPxrYDqi7U5hTHmLhKY/ZnWrOb4Cc0Ww+aeubog2p5N4mVIb 5l0BMs55q28H3zCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=archlinux.org; s=dkim-rsa; t=1658397133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=641DCOG5oP1SHnxRTokzUSxzH3s1Kx0VyISCZgh6heE=; b=I3JqWy5XE04cFsxavBDBq/S8ieq2NTP+15fkYQPUZXocPqjx/otJV2Ju6AV7QJzaYaEajW g0Xseni29M5XotqyHDuW17t6C+vVXwKwfFZPZdfv5vHjye0a5DqDKrtgJALvtLAMp7A6I/ 1JKjg3AzBr9UlVHoda7920bdF+uXqG7diJw2PZG+uVE7YoYq4LyUCEBSA+SxMhy41ZpkC6 LeJgjGSv70rIZ5HhsG1C8NScYATTS1/zMjvDvE2HgRnw4dM2jRqB1nHaPMf1KqBXKX9m1W qiByWG9CrwJG6ODn5fHk8cg9UkDLsD8YNzXxMK4O9FCuOBPELdgWIOVcUAG8Up6Qx87rIj hQyEYZ60QfU6IrPK3hRLIVdQ4cDTXxCp1DvxjeoHcl+Qro/Ubpv+0qQ00LEGP32UKXNcju xvWNA5bgZMVUA9Q8sZvO+i2tpj1zY1T0CYhu0ghG+2xmkc1VIRkfONYaQeueifjcnVjrqk mArydRpT+ZpNpN82RuUiYATXYi2PhdnV7TeZSC6WcEHWsjSLMnS0yHUwNbNGLL+xmShqg8 Kx01hiUK4yl2a49JDLRtPrOfZXy7TonyHrK2OWEtezQ8snuvFe6ztA5RLZCbZpjR56XRfD 1F1EkK28IdGJAaSQ8exhFESvBh1ZMGMD437tZ551zl7FmH3iolUkI= To: pacman-dev@lists.archlinux.org Subject: [PATCH] Correctly handle failure in getting build or install dates Date: Thu, 21 Jul 2022 19:51:51 +1000 Message-Id: <20220721095151.490686-1-allan@archlinux.org> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 X-BeenThere: pacman-dev@lists.archlinux.org X-Mailman-Version: 2.1.39 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: pacman-dev-bounces@lists.archlinux.org Sender: "pacman-dev" X-Spamd-Result: default: False [-2.61 / 15.00]; DWL_DNSWL_MED(-2.00)[archlinux.org:dkim]; MID_CONTAINS_FROM(1.00)[]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; DMARC_POLICY_ALLOW(-0.50)[archlinux.org,none]; R_MISSING_CHARSET(0.50)[]; RCVD_IN_DNSWL_MED(-0.40)[95.217.236.249:from,2a01:4f9:c010:3052::1:received]; R_DKIM_ALLOW(-0.20)[archlinux.org:s=dkim-ed25519,archlinux.org:s=dkim-rsa]; MAILLIST(-0.20)[mailman]; R_SPF_ALLOW(-0.20)[+ip4:95.217.236.249:c]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM(-0.00)[-0.998]; ASN(0.00)[asn:24940, ipnet:95.217.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; PREVIOUSLY_DELIVERED(0.00)[pacman-dev@lists.archlinux.org]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[archlinux.org:+]; TO_DN_NONE(0.00)[]; FROM_NEQ_ENVFROM(0.00)[allan@archlinux.org,pacman-dev-bounces@lists.archlinux.org]; RCPT_COUNT_ONE(0.00)[1]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Server: mail.archlinux.org X-Rspamd-Queue-Id: A93F112518BC Authentication-Results: mail.archlinux.org; dkim=pass header.d=archlinux.org header.s=dkim-ed25519 header.b=zt5vHG8z; dkim=pass header.d=archlinux.org header.s=dkim-rsa header.b=I3JqWy5X; dmarc=pass (policy=none) header.from=archlinux.org; spf=pass (mail.archlinux.org: domain of pacman-dev-bounces@lists.archlinux.org designates 95.217.236.249 as permitted sender) smtp.mailfrom=pacman-dev-bounces@lists.archlinux.org alpm_pkg_get_builddate() and alpm_pkg_get_installdate() both return -1 on error. Correctly handle the error condition in pacman. Signed-off-by: Allan McRae --- src/pacman/package.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pacman/package.c b/src/pacman/package.c index f2b6fa19..4fcc11f2 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -210,11 +210,11 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra) /* set variables here, do all output below */ bdate = (time_t)alpm_pkg_get_builddate(pkg); - if(bdate) { + if(bdate != -1) { strftime(bdatestr, 50, "%c", localtime(&bdate)); } idate = (time_t)alpm_pkg_get_installdate(pkg); - if(idate) { + if(idate != -1) { strftime(idatestr, 50, "%c", localtime(&idate)); }