libmakepkg: fix compatibility with bash-5.2 patsub_replacement

Message ID
State New
Headers show
Series libmakepkg: fix compatibility with bash-5.2 patsub_replacement | expand

Commit Message

Allan McRae Dec. 12, 2022, 8:43 a.m. UTC
Bash-5.2 introduced the patsub_replacement shell option, which is enabled
by default.  Apparently is it supposed to handle a sed-like idiom, but
what it does achieve is making any substitution involving a "&" requiring
special care.

For makepkg's DLAGENTS, we replace "%o" and "%u" if present.  Any "&" in
the replacement fields triggers patsub_replacement unless quoted.  This is
particularly important for the URL field.

Add relevant quotes to avoid issues.

Signed-off-by: Allan McRae <>

Posting to pacman-dev and not just to our gitlab so that this is flagged
for distros to backport when updating bash.

 scripts/libmakepkg/source/ | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


diff --git a/scripts/libmakepkg/source/ b/scripts/libmakepkg/source/
index fa09d446..10e0026e 100644
--- a/scripts/libmakepkg/source/
+++ b/scripts/libmakepkg/source/
@@ -60,11 +60,11 @@  download_file() {
 	# replace %o by the temporary dlfile if it exists
 	if [[ ${cmdline[*]} = *%o* ]]; then
-		cmdline=("${cmdline[@]//%o/$dlfile}")
+		cmdline=("${cmdline[@]//%o/"$dlfile"}")
 	# add the URL, either in place of %u or at the end
 	if [[ ${cmdline[*]} = *%u* ]]; then
-		cmdline=("${cmdline[@]//%u/$url}")
+		cmdline=("${cmdline[@]//%u/"$url"}")