| Message ID | 20220614234717.15172-1-allan@archlinux.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | Gitlab CI: remove valgrind test | expand |
On Wed, 15 Jun 2022 at 00:47, Allan McRae <allan@archlinux.org> wrote: > > Currently our gitlab CI is failing due to valgrind breakage. With > Arch stripping glibc, valgrind now requires debuginfod to be active. > However the gitlab CI system does not retrieve these symbols, even > when the appropriate environmental variable is set. > Can't we install the glibc-debug package or does valgrind insist on the debuginfod service? The install will require enabling the core-debug repo, which is annoying but doable. IMHO keeping the CI green is a number one priority. Don't see a reason to block your patch, even if my idea seems reasonable. HTH Emil
On 17/6/22 21:02, Emil Velikov wrote: > On Wed, 15 Jun 2022 at 00:47, Allan McRae <allan@archlinux.org> wrote: >> >> Currently our gitlab CI is failing due to valgrind breakage. With >> Arch stripping glibc, valgrind now requires debuginfod to be active. >> However the gitlab CI system does not retrieve these symbols, even >> when the appropriate environmental variable is set. >> > > Can't we install the glibc-debug package or does valgrind insist on > the debuginfod service? The install will require enabling the > core-debug repo, which is annoying but doable. > > IMHO keeping the CI green is a number one priority. Don't see a reason > to block your patch, even if my idea seems reasonable. > Forgot to send the updated patch. The following command is now added to the valgrind section: pacman -U --noconfirm https://geo.mirror.pkgbuild.com/core-debug/os/x86_64/glibc-debug-$(pacman -S --print-format %v glibc)-x86_64.pkg.tar.zst Not idea, but works!
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 186ad3dc..d9659746 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -46,13 +46,14 @@ arch-clang: - ninja -C build - fakechroot meson test -C build -arch-valgrind: - extends: .arch-test - script: - - pacman -Syu --needed --noconfirm valgrind - - meson build - - ninja -C build - - PACTEST_VALGRIND=1 fakechroot meson test -C build +# Fails due to lack of debug symbols in libc.so.6 and debuginfod not working +#arch-valgrind: +# extends: .arch-test +# script: +# - pacman -Syu --needed --noconfirm valgrind +# - meson build +# - ninja -C build +# - PACTEST_VALGRIND=1 fakechroot meson test -C build arch-nettle: extends: .arch-test
Currently our gitlab CI is failing due to valgrind breakage. With Arch stripping glibc, valgrind now requires debuginfod to be active. However the gitlab CI system does not retrieve these symbols, even when the appropriate environmental variable is set. If Arch is not appropriate for this test, we may want to switch to another distribution for valgrind. Signed-off-by: Allan McRae <allan@archlinux.org> --- This is a temporary patch to get CI running clean again. Still looking at how this can be fixed for Arch, otherwise I will switch the valgrind run to a distro with appropriate dependencies for valgrind to run. .gitlab-ci.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)