Message ID | 20210116072101.38203-7-andrew.gregory.8@gmail.com |
---|---|
State | Accepted, archived |
Headers | show
Return-Path: <pacman-dev-bounces@lists.archlinux.org> Delivered-To: patchwork@archlinux.org Received: from mail.archlinux.org [2a01:4f9:c010:3052::1] by patchwork.archlinux.org with IMAP (fetchmail-6.4.14) for <fetchmail@localhost> (single-drop); Sat, 16 Jan 2021 07:30:21 +0000 (UTC) Received: from mail.archlinux.org by mail.archlinux.org with LMTP id KZV7EQyWAmAIxAQAK+/4rw (envelope-from <pacman-dev-bounces@lists.archlinux.org>) for <patchwork@archlinux.org>; Sat, 16 Jan 2021 07:30:20 +0000 Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.archlinux.org (Postfix) with ESMTPS id 438AA3756E1; Sat, 16 Jan 2021 07:30:19 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 3229A2C5C8; Sat, 16 Jan 2021 07:23:34 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 03F362C558 for <pacman-dev@lists.archlinux.org>; Sat, 16 Jan 2021 07:23:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on luna.archlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=AC_FROM_MANY_DOTS=0.497, DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FROM=0.5, RCVD_IN_DNSWL_MED=-2.3,T_DMARC_POLICY_NONE=0.01, T_DMARC_SIMPLE_DKIM=0.01 autolearn=failed autolearn_force=no version=3.4.4 X-Spam-BL-Results: <dns:206.137.207.98.dnsbl.sorbs.net> [127.0.0.10] <dns:206.137.207.98.zen.spamhaus.org> [127.0.0.10] <dns:1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.5.0.3.0.1.0.c.9.f.4.0.1.0.a.2.list.dnswl.org> [127.0.9.2] Received: from mail.archlinux.org (mail.archlinux.org [IPv6:2a01:4f9:c010:3052::1]) by luna.archlinux.org (Postfix) with ESMTPS for <pacman-dev@lists.archlinux.org>; Sat, 16 Jan 2021 07:23:31 +0000 (UTC) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.archlinux.org (Postfix) with ESMTPS id 42D863756B8 for <pacman-dev@archlinux.org>; Sat, 16 Jan 2021 07:23:31 +0000 (UTC) Received: by mail-pl1-x634.google.com with SMTP id s15so5871376plr.9 for <pacman-dev@archlinux.org>; Fri, 15 Jan 2021 23:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yECqSFCqsxAAcDMsCCKXnPoJf8EKyNBM191Jmt8bQMY=; b=vXcHjpHfFSB3MsB20AQ/qk+NPA/Xpbc8zAmD31eLbzMkN1r/ER1Co9fcwLxjrihPTq snZEDtHqXVhX/Vpp3deSAtICYrF53ZjCjkMAo6f+fp3U7lysH1zq/n84qtdKPIXOEQc+ 37shjZHhNH6cZ9688Zj+OG0neQ338loXTh3R+yL1fi6498/Jx85fdlFF2PgaAV9v6jLd 9fkFO9pDhzXAUumwHsHSeCOQtjR/La1cQX7ccTpr02oDOOgmz8DP9eNhgaDpfi5ZTSqB tcCmqUoQP9Qi2Jg4RjhWdX+bZP+mR3+YgmWlpQCDP+8cs2WgHdoktg68InRvaBatB3CX cCoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yECqSFCqsxAAcDMsCCKXnPoJf8EKyNBM191Jmt8bQMY=; b=mCfsgopvaYJPxKA67ZyTMenRLy+2fqIQaRoQ0W7dEb06rwDfdKng9wdr9mwm05km2A 8YPSJhqZ8MUyTdDwYZ4rXO6BppOJm/dG5pPlTz88M6KKRIna5VuNnbbnnPGp40QK8md5 UzrPtjuS3xOYjMP7+Ly/P7IvwocUQ9xW5P21NevI0IUQ6i6dfiVQg/AhMUgy1Xv0oglv iKUpbjob6akO+FqAHMc0zxobIiD+DK3CJSPcsodk3JwTNWF2BEz1fP9o20fkDy4otRj8 x0+FOzZf6qAcvUOYTUKFMdvhlRgu/gtm17M4bf7cPy8nz6BtaK6G8KGfwrFUVYyAFrhY HMhg== X-Gm-Message-State: AOAM530ig1xEBhDPYxUnwwH+cYeN/pT5y+TfhAKxevOWIpsyealhjD0U YXnqVNtxU7MylyNe92qXqYUO41+s5AE= X-Google-Smtp-Source: ABdhPJydfORkx11fHPKOOw7+EemtJN3nWsspdMTs5MDkfOziRNoJcutHcFuRZY69M2JhU7aLDD2k8w== X-Received: by 2002:a17:903:228e:b029:de:2bee:150d with SMTP id b14-20020a170903228eb02900de2bee150dmr16395837plh.18.1610781809410; Fri, 15 Jan 2021 23:23:29 -0800 (PST) Received: from localhost.localdomain (c-98-207-137-206.hsd1.ca.comcast.net. [98.207.137.206]) by smtp.gmail.com with ESMTPSA id w25sm3850001pfg.103.2021.01.15.23.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 23:23:28 -0800 (PST) From: Andrew Gregory <andrew.gregory.8@gmail.com> To: pacman-dev@archlinux.org Cc: Andrew Gregory <andrew.gregory.8@gmail.com> Date: Fri, 15 Jan 2021 23:21:01 -0800 Message-Id: <20210116072101.38203-7-andrew.gregory.8@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [pacman-dev] [PATCH 7/7] do not try to download an empty db list X-BeenThere: pacman-dev@lists.archlinux.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion list for pacman development <pacman-dev.lists.archlinux.org> List-Unsubscribe: <https://lists.archlinux.org/options/pacman-dev>, <mailto:pacman-dev-request@lists.archlinux.org?subject=unsubscribe> List-Archive: <https://lists.archlinux.org/pipermail/pacman-dev/> List-Post: <mailto:pacman-dev@lists.archlinux.org> List-Help: <mailto:pacman-dev-request@lists.archlinux.org?subject=help> List-Subscribe: <https://lists.archlinux.org/listinfo/pacman-dev>, <mailto:pacman-dev-request@lists.archlinux.org?subject=subscribe> Reply-To: Discussion list for pacman development <pacman-dev@lists.archlinux.org> Errors-To: pacman-dev-bounces@lists.archlinux.org Sender: "pacman-dev" <pacman-dev-bounces@lists.archlinux.org> Authentication-Results: mail.archlinux.org; dkim=fail (headers rsa verify failed) header.d=gmail.com header.s=20161025 header.b=vXcHjpHf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (mail.archlinux.org: domain of pacman-dev-bounces@lists.archlinux.org designates 2a01:4f8:160:3033::2 as permitted sender) smtp.mailfrom=pacman-dev-bounces@lists.archlinux.org X-Rspamd-Queue-Id: 438AA3756E1 X-Spamd-Result: default: False [4.59 / 15.00]; HAS_REPLYTO(0.00)[pacman-dev@lists.archlinux.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; GREYLIST(0.00)[pass,meta]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:160:3033::2:c]; R_DKIM_REJECT(1.00)[gmail.com:s=20161025]; FREEMAIL_FROM(0.00)[gmail.com]; BROKEN_CONTENT_TYPE(1.50)[]; R_MISSING_CHARSET(2.50)[]; NEURAL_SPAM(0.00)[0.996]; DKIM_TRACE(0.00)[gmail.com:-]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; RECEIVED_SPAMHAUS_PBL(0.00)[98.207.137.206:received]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[andrewgregory8@gmail.com,pacman-dev-bounces@lists.archlinux.org]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_LIST_UNSUB(-0.01)[]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_COUNT_SEVEN(0.00)[7]; FORGED_SENDER_MAILLIST(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : SPF not aligned (relaxed),none] X-Rspamd-Server: mail.archlinux.org |
Series |
[pacman-dev,1/7] pacman: indicate --overwrite takes a glob
|
expand
|
diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index 0a5cb7c2..91e5f5cf 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -198,6 +198,10 @@ int SYMEXPORT alpm_db_update(alpm_handle_t *handle, alpm_list_t *dbs, int force) payload->max_size = 128 * 1024 * 1024; payloads = alpm_list_add(payloads, payload); } + if(payloads == NULL) { + ret = 0; + goto cleanup; + } event.type = ALPM_EVENT_DB_RETRIEVE_START; EVENT(handle, &event);
Starting the download process, even if there is nothing to actually download, causes an error when pacman is built without curl and has no XferCommand defined (like our test suite). Signed-off-by: Andrew Gregory <andrew.gregory.8@gmail.com> --- lib/libalpm/be_sync.c | 4 ++++ 1 file changed, 4 insertions(+)