| Message ID | 20201124123908.2096891-1-morganamilo@archlinux.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [pacman-dev,1/5] libalpm: set parallel_downloads to 1 when creating the handle | expand |
On 24/11/20 10:39 pm, morganamilo wrote: > Fixes FS#68729 > > diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c > index 34c5b4b2..5d36136d 100644 > --- a/lib/libalpm/alpm.c > +++ b/lib/libalpm/alpm.c > @@ -61,6 +61,8 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath, > /* set default database extension */ > STRDUP(myhandle->dbext, ".db", goto nomem); > > + myhandle->parallel_downloads = 1; > + > lockfilelen = strlen(myhandle->dbpath) + strlen(lf) + 1; > MALLOC(myhandle->lockfile, lockfilelen, goto nomem); > snprintf(myhandle->lockfile, lockfilelen, "%s%s", myhandle->dbpath, lf); > Thanks - I moved that line right under the curl bit to keep download stuff together. Allan
Hi On Wed, Nov 25, 2020 at 10:20 PM Allan McRae <allan@archlinux.org> wrote: > > On 24/11/20 10:39 pm, morganamilo wrote: > > Fixes FS#68729 > > > > diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c > > index 34c5b4b2..5d36136d 100644 > > --- a/lib/libalpm/alpm.c > > +++ b/lib/libalpm/alpm.c > > @@ -61,6 +61,8 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath, > > /* set default database extension */ > > STRDUP(myhandle->dbext, ".db", goto nomem); > > > > + myhandle->parallel_downloads = 1; > > + > > lockfilelen = strlen(myhandle->dbpath) + strlen(lf) + 1; > > MALLOC(myhandle->lockfile, lockfilelen, goto nomem); > > snprintf(myhandle->lockfile, lockfilelen, "%s%s", myhandle->dbpath, lf); > > > > Thanks - I moved that line right under the curl bit to keep download > stuff together. Thank you. The patch LGTM. The move to the curl section sounds good.
diff --git a/lib/libalpm/alpm.c b/lib/libalpm/alpm.c index 34c5b4b2..5d36136d 100644 --- a/lib/libalpm/alpm.c +++ b/lib/libalpm/alpm.c @@ -61,6 +61,8 @@ alpm_handle_t SYMEXPORT *alpm_initialize(const char *root, const char *dbpath, /* set default database extension */ STRDUP(myhandle->dbext, ".db", goto nomem); + myhandle->parallel_downloads = 1; + lockfilelen = strlen(myhandle->dbpath) + strlen(lf) + 1; MALLOC(myhandle->lockfile, lockfilelen, goto nomem); snprintf(myhandle->lockfile, lockfilelen, "%s%s", myhandle->dbpath, lf);