Message ID | 20200713163521.58405-1-anatol.pomozov@gmail.com |
---|---|
State | Accepted, archived |
Headers | show
Return-Path: <pacman-dev-bounces@archlinux.org> Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 1C26F19E91373 for <patchwork@archlinux.org>; Mon, 13 Jul 2020 16:35:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on apollo.archlinux.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_ADSP_CUSTOM_MED=0.001, DKIM_INVALID=1,DKIM_SIGNED=0.1,FREEMAIL_FROM=0.5,MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3,RCVD_IN_MSPIKE_H4=-0.01,RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001,T_DMARC_POLICY_NONE=0.01,T_DMARC_SIMPLE_DKIM=0.01 autolearn=ham autolearn_force=no version=3.4.4 X-Spam-BL-Results: <dns:70.91.198.88.wl.mailspike.net> [127.0.0.19] <dns:79.31.222.73.dnsbl.sorbs.net> [127.0.0.10] <dns:70.91.198.88.list.dnswl.org> [127.0.9.2] <dns:79.31.222.73.zen.spamhaus.org> [127.0.0.10] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for <patchwork@archlinux.org>; Mon, 13 Jul 2020 16:35:36 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 004E81D35C85AD; Mon, 13 Jul 2020 16:35:32 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [5.9.250.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: luna) by orion.archlinux.org (Postfix) with ESMTPSA id 6AD801D35C85A5; Mon, 13 Jul 2020 16:35:32 +0000 (UTC) Authentication-Results: orion.archlinux.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BhZW2eLE Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 1389B29CB0; Mon, 13 Jul 2020 16:35:32 +0000 (UTC) Authentication-Results: luna.archlinux.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BhZW2eLE Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 5541729CAF for <pacman-dev@lists.archlinux.org>; Mon, 13 Jul 2020 16:35:29 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for <pacman-dev@lists.archlinux.org>; Mon, 13 Jul 2020 16:35:29 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 6918B1D35C85A0 for <pacman-dev@archlinux.org>; Mon, 13 Jul 2020 16:35:27 +0000 (UTC) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS for <pacman-dev@archlinux.org>; Mon, 13 Jul 2020 16:35:27 +0000 (UTC) Received: by mail-pf1-x441.google.com with SMTP id 1so6230053pfn.9 for <pacman-dev@archlinux.org>; Mon, 13 Jul 2020 09:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nuQJcTJ5itjw+xGUkjxGoKHyUofWEAldA4ixv9sjE+o=; b=BhZW2eLEHJNpyKLy8WR7wIFVvijAo0ax38o8BRvO0QyfCbJr3a9KXqWzkPhn/RZkTv pXgRcd97avX25ZC1jUOI659Q08GArupTePr+FlTC+xRvIfA3oLw07AA4caRwQqyoTos2 VEacb4eKnA/i06JTGLNR+ycF5uaGgnnmGBZkZOJi2qFtkfHMUGatZmFOIoB62zZe2IuC XkINh+3dzAgtbcISfcC7VIj4DqtJMB6TUKZFPhNX2CiGSHCTZegcALlTG3bNs+6SDkMb yCBMFT4ZH10p7qtA+hZRrK12Wd3UzyfIbUIyBLfkrteGRWrbQrON3mQDQq3u981N2/1t 5K3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nuQJcTJ5itjw+xGUkjxGoKHyUofWEAldA4ixv9sjE+o=; b=g0/ztMw8AkEPcBgDB4MKAYMKM8i6XD0LtE1pjo2JW7D1maP3QvHXeooAb8iQ7StzE7 h8QstxTR7sJNrnnevPkv66Zms+qclKCEYVAxGVn9pZxDOJ0NsBWokWk1lETJ89jPyd4m XE2RTO6JxnOwmk4EDPRTe9x99J0eXBz3P/27yIO9O4TMqy3EkM0J++50bK5/1rh0erkX XdBOz9vvvNlOe9uMTVHBYj5Uxs/9FO9hZR9pDQJOwH6oSJW+eJ2CgebLAp+Om6Okhr90 JlI5V35i2HRzjB0mI7GapGrcNNwXPVRxJiJagVP9257FOuXQ3C/rbaRLdsi4aO5oLNV2 CdBA== X-Gm-Message-State: AOAM533RVQoNHfP/719TVEFMaTb5Z0JK34FaVoQ7y2682QufmjK9nkea BlclP+m1vxX2UK82o6CZ0iOI+DIzEkI= X-Google-Smtp-Source: ABdhPJzb18Njr6Z+rY+cpvcNjEY7HT4FF1+qu+NEY1uyOofzUVElHpVl5PJEn8lDBdWk6LmL590DUA== X-Received: by 2002:a05:6a00:1342:: with SMTP id k2mr663441pfu.32.1594658124655; Mon, 13 Jul 2020 09:35:24 -0700 (PDT) Received: from wolf.lan (c-73-222-31-79.hsd1.ca.comcast.net. [73.222.31.79]) by smtp.gmail.com with ESMTPSA id 66sm15069404pfg.63.2020.07.13.09.35.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 09:35:24 -0700 (PDT) From: Anatol Pomozov <anatol.pomozov@gmail.com> To: pacman-dev@archlinux.org Date: Mon, 13 Jul 2020 09:35:21 -0700 Message-Id: <20200713163521.58405-1-anatol.pomozov@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [pacman-dev] [PATCH] Do not free payload fields in the middle of this structure use X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussion list for pacman development <pacman-dev.archlinux.org> List-Unsubscribe: <https://lists.archlinux.org/options/pacman-dev>, <mailto:pacman-dev-request@archlinux.org?subject=unsubscribe> List-Archive: <https://lists.archlinux.org/pipermail/pacman-dev/> List-Post: <mailto:pacman-dev@archlinux.org> List-Help: <mailto:pacman-dev-request@archlinux.org?subject=help> List-Subscribe: <https://lists.archlinux.org/listinfo/pacman-dev>, <mailto:pacman-dev-request@archlinux.org?subject=subscribe> Reply-To: Discussion list for pacman development <pacman-dev@archlinux.org> Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" <pacman-dev-bounces@archlinux.org> |
Series |
[pacman-dev] Do not free payload fields in the middle of this structure use
|
expand
|
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 1785dd6a..343f5c78 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -698,10 +698,6 @@ static int curl_add_payload(alpm_handle_t *handle, CURLM *curlm, return 0; cleanup: - FREE(payload->fileurl); - FREE(payload->tempfile_name); - FREE(payload->destfile_name); - FREE(payload->content_disp_name); curl_easy_cleanup(curl); return ret; }
At the end of payload use it calls _alpm_dload_payload_reset() that will free() these and other fields anyway. Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com> --- lib/libalpm/dload.c | 4 ---- 1 file changed, 4 deletions(-)