| Message ID | 20200510043240.1631106-3-eschwartz@archlinux.org |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [pacman-dev,1/3] pacman-conf: add support for new ParallelDownloads config option | expand |
On 10/5/20 2:32 pm, Eli Schwartz wrote: > This was only partially implemented in the original implementation. > `pacman-conf | grep ILoveCandy` would tell you if it was set, but > querying directly by name would not. > OK. Note "half-baked" can have negative connotations, while "incomplete" specifies that issue without being accusatory. > Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> > --- > src/pacman/pacman-conf.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c > index d76c0985..463badf1 100644 > --- a/src/pacman/pacman-conf.c > +++ b/src/pacman/pacman-conf.c > @@ -379,6 +379,8 @@ static int list_directives(void) > show_bool("VerbosePkgLists", config->verbosepkglists); > } else if(strcasecmp(i->data, "DisableDownloadTimeout") == 0) { > show_bool("DisableDownloadTimeout", config->disable_dl_timeout); > + } else if(strcasecmp(i->data, "ILoveCandy") == 0) { > + show_bool("ILoveCandy", config->chomp); > } else if(strcasecmp(i->data, "NoProgressBar") == 0) { > show_bool("NoProgressBar", config->noprogressbar); > >
On 5/10/20 4:06 AM, Allan McRae wrote: > On 10/5/20 2:32 pm, Eli Schwartz wrote: >> This was only partially implemented in the original implementation. >> `pacman-conf | grep ILoveCandy` would tell you if it was set, but >> querying directly by name would not. >> > > OK. > > Note "half-baked" can have negative connotations, while "incomplete" > specifies that issue without being accusatory. Feel free to exchange the commit message with that text, and chalk it up to late-night coding. :D
diff --git a/src/pacman/pacman-conf.c b/src/pacman/pacman-conf.c index d76c0985..463badf1 100644 --- a/src/pacman/pacman-conf.c +++ b/src/pacman/pacman-conf.c @@ -379,6 +379,8 @@ static int list_directives(void) show_bool("VerbosePkgLists", config->verbosepkglists); } else if(strcasecmp(i->data, "DisableDownloadTimeout") == 0) { show_bool("DisableDownloadTimeout", config->disable_dl_timeout); + } else if(strcasecmp(i->data, "ILoveCandy") == 0) { + show_bool("ILoveCandy", config->chomp); } else if(strcasecmp(i->data, "NoProgressBar") == 0) { show_bool("NoProgressBar", config->noprogressbar);
This was only partially implemented in the original implementation. `pacman-conf | grep ILoveCandy` would tell you if it was set, but querying directly by name would not. Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> --- src/pacman/pacman-conf.c | 2 ++ 1 file changed, 2 insertions(+)