| Message ID | 20200504022749.275105-1-uhhadd@gmail.com |
|---|---|
| State | Rejected, archived |
| Headers | show |
| Series | [pacman-dev] Add makedepends to -Si/-Qi output | expand |
On 4/5/20 12:27 pm, Carson Black wrote: > Fairly self explanatory patch. pacman didn't show makedepends, now it > does. I guess you never tested this for -Qi. Makedepends are not stored in the local database. Also, makedepends are not important for installing a package, which is what -S operations are about. So I don't think they should be displayed in -Si > Signed-off-by: Carson Black <uhhadd@gmail.com> > --- > src/pacman/package.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/pacman/package.c b/src/pacman/package.c > index 4c93a443..c3c3dbf6 100644 > --- a/src/pacman/package.c > +++ b/src/pacman/package.c > @@ -70,6 +70,7 @@ enum { > T_URL, > T_VALIDATED_BY, > T_VERSION, > + T_BUILD_DEPENDS_ON, > /* the following is a sentinel and should remain in last position */ > _T_MAX > }; > @@ -124,6 +125,7 @@ static void make_aligned_titles(void) > buf[T_URL] = _("URL"); > buf[T_VALIDATED_BY] = _("Validated By"); > buf[T_VERSION] = _("Version"); > + buf[T_BUILD_DEPENDS_ON] = _("Build Depends On"); > > for(i = 0; i < ARRAYSIZE(wbuf); i++) { > wlen[i] = mbstowcs(wbuf[i], buf[i], strlen(buf[i]) + 1); > @@ -271,6 +273,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra) > list_display(titles[T_GROUPS], alpm_pkg_get_groups(pkg), cols); > deplist_display(titles[T_PROVIDES], alpm_pkg_get_provides(pkg), cols); > deplist_display(titles[T_DEPENDS_ON], alpm_pkg_get_depends(pkg), cols); > + deplist_display(titles[T_BUILD_DEPENDS_ON], alpm_pkg_get_makedepends(pkg), cols); > optdeplist_display(pkg, cols); > > if(extra || from == ALPM_PKG_FROM_LOCALDB) { >
diff --git a/src/pacman/package.c b/src/pacman/package.c index 4c93a443..c3c3dbf6 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -70,6 +70,7 @@ enum { T_URL, T_VALIDATED_BY, T_VERSION, + T_BUILD_DEPENDS_ON, /* the following is a sentinel and should remain in last position */ _T_MAX }; @@ -124,6 +125,7 @@ static void make_aligned_titles(void) buf[T_URL] = _("URL"); buf[T_VALIDATED_BY] = _("Validated By"); buf[T_VERSION] = _("Version"); + buf[T_BUILD_DEPENDS_ON] = _("Build Depends On"); for(i = 0; i < ARRAYSIZE(wbuf); i++) { wlen[i] = mbstowcs(wbuf[i], buf[i], strlen(buf[i]) + 1); @@ -271,6 +273,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra) list_display(titles[T_GROUPS], alpm_pkg_get_groups(pkg), cols); deplist_display(titles[T_PROVIDES], alpm_pkg_get_provides(pkg), cols); deplist_display(titles[T_DEPENDS_ON], alpm_pkg_get_depends(pkg), cols); + deplist_display(titles[T_BUILD_DEPENDS_ON], alpm_pkg_get_makedepends(pkg), cols); optdeplist_display(pkg, cols); if(extra || from == ALPM_PKG_FROM_LOCALDB) {
Fairly self explanatory patch. pacman didn't show makedepends, now it does. Signed-off-by: Carson Black <uhhadd@gmail.com> --- src/pacman/package.c | 3 +++ 1 file changed, 3 insertions(+)