diff mbox

[pacman-dev] makepkg: when signing packages, report package filename on failure

Message ID 20180612140029.25787-1-eschwartz@archlinux.org
State Accepted, archived
Headers show

Commit Message

Eli Schwartz June 12, 2018, 2 p.m. UTC
In commit c6b04c04653ba9933fe978829148312e412a9ea7 the signing function
was moved out of fakeroot, and thus out of the create_package loop. This
meant that if package signing failed, it was no longer possible to tell
which package it failed on by checking which package creation is
currently running. Successful signing attempts do not have this problem
as we already printed the name of the signature file.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
---
 scripts/libmakepkg/integrity/generate_signature.sh.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/scripts/libmakepkg/integrity/generate_signature.sh.in b/scripts/libmakepkg/integrity/generate_signature.sh.in
index 261b18f7..1567ee89 100644
--- a/scripts/libmakepkg/integrity/generate_signature.sh.in
+++ b/scripts/libmakepkg/integrity/generate_signature.sh.in
@@ -40,7 +40,7 @@  create_signature() {
 	if (( ! ret )); then
 		msg2 "$(gettext "Created signature file %s.")" "${filename##*/}.sig"
 	else
-		warning "$(gettext "Failed to sign package file.")"
+		warning "$(gettext "Failed to sign package file %s.")" "${filename##*/}"
 	fi
 
 	return $ret