diff mbox

[pacman-dev] makepkg: use localized date strings

Message ID 20180210172752.27436-1-yan12125@gmail.com
State Accepted, archived
Headers show

Commit Message

Chih-Hsuan Yen Feb. 10, 2018, 5:27 p.m. UTC
From: Yen Chi Hsuan <yan12125@gmail.com>

Before this change, LC_TIME=zh_TW.UTF-8 makepkg has the following line:

==> Making package: foobar 1-1 (日  2月 11 01:13:42 CST 2018)

With this patch, this line becomes:

==> Making package: foobar 1-1 (西元2018年02月11日 (週日) 01時13分57秒)

The latter is more natural for a Chinese native speaker.

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
---
 scripts/makepkg.sh.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Chih-Hsuan Yen March 7, 2018, 4:03 a.m. UTC | #1
Hello,

Does this patch requires more work? Or I was doing something wrong in
submitting patches? I'll be grateful for any further feedback.

Best Regards,

Chih-Hsuan Yen

2018-02-11 1:27 GMT+08:00 Chih-Hsuan Yen <yan12125@gmail.com>:
> From: Yen Chi Hsuan <yan12125@gmail.com>
>
> Before this change, LC_TIME=zh_TW.UTF-8 makepkg has the following line:
>
> ==> Making package: foobar 1-1 (日  2月 11 01:13:42 CST 2018)
>
> With this patch, this line becomes:
>
> ==> Making package: foobar 1-1 (西元2018年02月11日 (週日) 01時13分57秒)
>
> The latter is more natural for a Chinese native speaker.
>
> Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
> ---
>  scripts/makepkg.sh.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 63b6c3e1..5e3af337 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1569,7 +1569,7 @@ if (( INFAKEROOT )); then
>         exit $E_OK
>  fi
>
> -msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date))"
> +msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date +%c))"
>
>  # if we are creating a source-only package, go no further
>  if (( SOURCEONLY )); then
> @@ -1597,7 +1597,7 @@ if (( SOURCEONLY )); then
>         msg "$(gettext "Signing package...")"
>         create_signature "$SRCPKGDEST/${pkgbase}-${fullver}${SRCEXT}"
>
> -       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date))"
> +       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date +%c))"
>         exit $E_OK
>  fi
>
> @@ -1703,7 +1703,7 @@ if (( NOARCHIVE )); then
>         exit $E_OK
>  fi
>
> -msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date))"
> +msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date +%c))"
>
>  install_package && exit $E_OK || exit $E_INSTALL_FAILED
>
> --
> 2.16.1
>
Silvan Jegen March 7, 2018, 7:56 a.m. UTC | #2
Hi

On Wed, Mar 7, 2018 at 5:03 AM, Chih-Hsuan Yen <yan12125@gmail.com> wrote:
> Does this patch requires more work? Or I was doing something wrong in
> submitting patches? I'll be grateful for any further feedback.

It seems like a reasonable change to me but I am a little bit worried
about it because it will change the formatting of the printed time for
all users. It also depends on the locale the user has set so it may
result in issues if people have not set up their locale properly.

Lastly I am also not sure if the +%c formatting option is supported on
all Unix-like platforms. On FreeBSD that option does seem to be
supported: https://www.freebsd.org/cgi/man.cgi?date &&
https://www.freebsd.org/cgi/man.cgi?query=strftime&sektion=3&apropos=0&manpath=FreeBSD+11.1-RELEASE+and+Ports
but I don't know about other BSDs, Darwin, ...


Cheers,

Silvan


>
> Best Regards,
>
> Chih-Hsuan Yen
>
> 2018-02-11 1:27 GMT+08:00 Chih-Hsuan Yen <yan12125@gmail.com>:
>> From: Yen Chi Hsuan <yan12125@gmail.com>
>>
>> Before this change, LC_TIME=zh_TW.UTF-8 makepkg has the following line:
>>
>> ==> Making package: foobar 1-1 (日  2月 11 01:13:42 CST 2018)
>>
>> With this patch, this line becomes:
>>
>> ==> Making package: foobar 1-1 (西元2018年02月11日 (週日) 01時13分57秒)
>>
>> The latter is more natural for a Chinese native speaker.
>>
>> Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
>> ---
>>  scripts/makepkg.sh.in | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
>> index 63b6c3e1..5e3af337 100644
>> --- a/scripts/makepkg.sh.in
>> +++ b/scripts/makepkg.sh.in
>> @@ -1569,7 +1569,7 @@ if (( INFAKEROOT )); then
>>         exit $E_OK
>>  fi
>>
>> -msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date))"
>> +msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date +%c))"
>>
>>  # if we are creating a source-only package, go no further
>>  if (( SOURCEONLY )); then
>> @@ -1597,7 +1597,7 @@ if (( SOURCEONLY )); then
>>         msg "$(gettext "Signing package...")"
>>         create_signature "$SRCPKGDEST/${pkgbase}-${fullver}${SRCEXT}"
>>
>> -       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date))"
>> +       msg "$(gettext "Source package created: %s")" "$pkgbase ($(date +%c))"
>>         exit $E_OK
>>  fi
>>
>> @@ -1703,7 +1703,7 @@ if (( NOARCHIVE )); then
>>         exit $E_OK
>>  fi
>>
>> -msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date))"
>> +msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date +%c))"
>>
>>  install_package && exit $E_OK || exit $E_INSTALL_FAILED
>>
>> --
>> 2.16.1
>>
Allan McRae March 7, 2018, 10:09 a.m. UTC | #3
On 07/03/18 17:56, Silvan Jegen wrote:
> On FreeBSD that option does seem to be
> supported: https://www.freebsd.org/cgi/man.cgi?date

Right on the page you linked...
     %c	   is replaced by national representation of time and date.
Allan McRae March 7, 2018, 10:11 a.m. UTC | #4
On 07/03/18 14:03, Chih-Hsuan Yen wrote:
> Hello,
> 
> Does this patch requires more work? Or I was doing something wrong in
> submitting patches? I'll be grateful for any further feedback.
> 

The patch looks fine.   I have not had time to do a patch round up the
last month so patches are just sitting in my todo list currently.  My
time should free up again next week (maybe...  I will be travelling).

A
Silvan Jegen March 7, 2018, 1:30 p.m. UTC | #5
On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <allan@archlinux.org> wrote:
> On 07/03/18 17:56, Silvan Jegen wrote:
>> On FreeBSD that option does seem to be
>> supported: https://www.freebsd.org/cgi/man.cgi?date
>
> Right on the page you linked...
>      %c    is replaced by national representation of time and date.

Yes, that's why I linked it. I am not sure if it's supported on the
other BSDs and/or MacOSX though, that is what I was trying to say. If
all BSDs use the same version of date(1) then I assume adding this
option is probably fine.
Andrew Gregory March 7, 2018, 1:50 p.m. UTC | #6
On 03/07/18 at 02:30pm, Silvan Jegen wrote:
> On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <allan@archlinux.org> wrote:
> > On 07/03/18 17:56, Silvan Jegen wrote:
> >> On FreeBSD that option does seem to be
> >> supported: https://www.freebsd.org/cgi/man.cgi?date
> >
> > Right on the page you linked...
> >      %c    is replaced by national representation of time and date.
> 
> Yes, that's why I linked it. I am not sure if it's supported on the
> other BSDs and/or MacOSX though, that is what I was trying to say. If
> all BSDs use the same version of date(1) then I assume adding this
> option is probably fine.

%c is specified by POSIX
Silvan Jegen March 7, 2018, 3:17 p.m. UTC | #7
On Wed, Mar 7, 2018 at 2:50 PM, Andrew Gregory
<andrew.gregory.8@gmail.com> wrote:
> On 03/07/18 at 02:30pm, Silvan Jegen wrote:
>> On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <allan@archlinux.org> wrote:
>> > On 07/03/18 17:56, Silvan Jegen wrote:
>> >> On FreeBSD that option does seem to be
>> >> supported: https://www.freebsd.org/cgi/man.cgi?date
>> >
>> > Right on the page you linked...
>> >      %c    is replaced by national representation of time and date.
>>
>> Yes, that's why I linked it. I am not sure if it's supported on the
>> other BSDs and/or MacOSX though, that is what I was trying to say. If
>> all BSDs use the same version of date(1) then I assume adding this
>> option is probably fine.
>
> %c is specified by POSIX

I was hoping for the man page to mention that this formatting option
is POSIX but I didn't.

If it's POSIX then this change should be ok. The formatting of the
date command will change for a lot of users but I assume that should
be fine.
Chih-Hsuan Yen March 8, 2018, 12:54 p.m. UTC | #8
2018-03-07 23:17 GMT+08:00 Silvan Jegen <s.jegen@gmail.com>:
> On Wed, Mar 7, 2018 at 2:50 PM, Andrew Gregory
> <andrew.gregory.8@gmail.com> wrote:
>> On 03/07/18 at 02:30pm, Silvan Jegen wrote:
>>> On Wed, Mar 7, 2018 at 11:09 AM, Allan McRae <allan@archlinux.org> wrote:
>>> > On 07/03/18 17:56, Silvan Jegen wrote:
>>> >> On FreeBSD that option does seem to be
>>> >> supported: https://www.freebsd.org/cgi/man.cgi?date
>>> >
>>> > Right on the page you linked...
>>> >      %c    is replaced by national representation of time and date.
>>>
>>> Yes, that's why I linked it. I am not sure if it's supported on the
>>> other BSDs and/or MacOSX though, that is what I was trying to say. If
>>> all BSDs use the same version of date(1) then I assume adding this
>>> option is probably fine.
>>
>> %c is specified by POSIX
>
> I was hoping for the man page to mention that this formatting option
> is POSIX but I didn't.
>
> If it's POSIX then this change should be ok. The formatting of the
> date command will change for a lot of users but I assume that should
> be fine.

Looks like %c is specified in POSIX.1-2008 [1]:

%c    Locale's appropriate date and time representation.

[1] http://pubs.opengroup.org/onlinepubs/9699919799/utilities/date.html
Allan McRae March 14, 2018, 2:30 a.m. UTC | #9
On 11/02/18 03:27, Chih-Hsuan Yen wrote:
> From: Yen Chi Hsuan <yan12125@gmail.com>
> 
> Before this change, LC_TIME=zh_TW.UTF-8 makepkg has the following line:
> 
> ==> Making package: foobar 1-1 (日  2月 11 01:13:42 CST 2018)
> 
> With this patch, this line becomes:
> 
> ==> Making package: foobar 1-1 (西元2018年02月11日 (週日) 01時13分57秒)
> 
> The latter is more natural for a Chinese native speaker.
> 

Applied - Thanks,
A
diff mbox

Patch

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 63b6c3e1..5e3af337 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -1569,7 +1569,7 @@  if (( INFAKEROOT )); then
 	exit $E_OK
 fi
 
-msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date))"
+msg "$(gettext "Making package: %s")" "$pkgbase $basever ($(date +%c))"
 
 # if we are creating a source-only package, go no further
 if (( SOURCEONLY )); then
@@ -1597,7 +1597,7 @@  if (( SOURCEONLY )); then
 	msg "$(gettext "Signing package...")"
 	create_signature "$SRCPKGDEST/${pkgbase}-${fullver}${SRCEXT}"
 
-	msg "$(gettext "Source package created: %s")" "$pkgbase ($(date))"
+	msg "$(gettext "Source package created: %s")" "$pkgbase ($(date +%c))"
 	exit $E_OK
 fi
 
@@ -1703,7 +1703,7 @@  if (( NOARCHIVE )); then
 	exit $E_OK
 fi
 
-msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date))"
+msg "$(gettext "Finished making: %s")" "$pkgbase $basever ($(date +%c))"
 
 install_package && exit $E_OK || exit $E_INSTALL_FAILED