| Message ID | 20171008065024.12604-3-eschwartz@archlinux.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [pacman-dev,v2,1/3] makepkg: refactor archive compression for reusability | expand |
On 08/10/17 16:50, Eli Schwartz wrote: > Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> > --- > > I'm now wondering if it makes sense to import > libmakepkg/util/compress.sh here for reuse. Currently repo-add checks > the extensions twice and aborts on unknown extensions, but I'm not sure > why we need to be stricter here than in makepkg itself. > OK - but won't be pulled until a new libarchive release is made. Also, we are not setup to use libmakepkg in repo-add. And I have vague plans to make repo-add a libalpm based program, so it is probably not worth it. A
diff --git a/scripts/repo-add.sh.in b/scripts/repo-add.sh.in index 41a2ea93..76c3ee46 100644 --- a/scripts/repo-add.sh.in +++ b/scripts/repo-add.sh.in @@ -300,6 +300,7 @@ verify_repo_extension() { *.db.tar.gz) TAR_OPT="z" ;; *.db.tar.bz2) TAR_OPT="j" ;; *.db.tar.xz) TAR_OPT="J" ;; + *.db.tar.zst) TAR_OPT="--zstd" ;; *.db.tar.Z) TAR_OPT="Z" ;; *.db.tar) TAR_OPT="" ;; *) error "$(gettext "'%s' does not have a valid database archive extension.")" \
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org> --- I'm now wondering if it makes sense to import libmakepkg/util/compress.sh here for reuse. Currently repo-add checks the extensions twice and aborts on unknown extensions, but I'm not sure why we need to be stricter here than in makepkg itself. scripts/repo-add.sh.in | 1 + 1 file changed, 1 insertion(+)