diff mbox

[pacman-dev] Fix coding style issue in pacman/util.c

Message ID 20170713193059.20710-1-straubem@gmx.de
State Accepted, archived
Headers show

Commit Message

Michael Straube July 13, 2017, 7:30 p.m. UTC 
Add missing braces to some one-line if blocks.

Signed-off-by: Michael Straube <straubem@gmx.de>
---
 src/pacman/util.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Comments

Allan McRae July 28, 2017, 2:33 a.m. UTC | #1 
On 14/07/17 05:30, Michael Straube wrote:
> Add missing braces to some one-line if blocks.
> 
> Signed-off-by: Michael Straube <straubem@gmx.de>

I'll pull these patches, but for future reference I really don't like
patches just to fix minor coding style violations unless they are part
of a patchset touching the same area.

A
diff mbox

Patch

diff --git a/src/pacman/util.c b/src/pacman/util.c
index ae8a74d3..9784d627 100644
--- a/src/pacman/util.c
+++ b/src/pacman/util.c
@@ -1299,8 +1299,9 @@  void select_display(const alpm_list_t *pkglist)
 		alpm_pkg_t *pkg = i->data;
 		alpm_db_t *db = alpm_pkg_get_db(pkg);
 
-		if(!dbname)
+		if(!dbname) {
 			dbname = alpm_db_get_name(db);
+		}
 		if(strcmp(alpm_db_get_name(db), dbname) != 0) {
 			display_repo_list(dbname, list, cols);
 			FREELIST(list);
@@ -1349,8 +1350,9 @@  static int multiselect_parse(char *array, int count, char *response)
 			break;
 		}
 		len = strtrim(starts);
-		if(len == 0)
+		if(len == 0) {
 			continue;
+		}
 
 		if(*starts == '^') {
 			starts++;
@@ -1370,8 +1372,9 @@  static int multiselect_parse(char *array, int count, char *response)
 			}
 		}
 
-		if(parseindex(starts, &start, 1, count) != 0)
+		if(parseindex(starts, &start, 1, count) != 0) {
 			return -1;
+		}
 
 		if(!ends) {
 			array[start - 1] = include;
@@ -1495,8 +1498,9 @@  int select_question(int count)
 			size_t len = strtrim(response);
 			if(len > 0) {
 				int n;
-				if(parseindex(response, &n, 1, count) != 0)
+				if(parseindex(response, &n, 1, count) != 0) {
 					continue;
+				}
 				return (n - 1);
 			}
 		}