From patchwork Fri Jun 8 18:18:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: morganamilo X-Patchwork-Id: 589 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id D54E44B22360 for ; Fri, 8 Jun 2018 18:19:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on apollo X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_ADSP_CUSTOM_MED=0.001, DKIM_SIGNED=0.1,FREEMAIL_FROM=0.5,MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_MED=-2.3,T_DKIM_INVALID=1 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-BL-Results: [127.0.0.11] [127.0.0.10] [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Fri, 8 Jun 2018 18:19:13 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 864D9B1D81BEB; Fri, 8 Jun 2018 18:19:12 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Fri, 8 Jun 2018 18:19:12 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 53F5A2C5DD; Fri, 8 Jun 2018 18:19:12 +0000 (UTC) Authentication-Results: luna.archlinux.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pib0RF7A Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 108CF2D415 for ; Fri, 8 Jun 2018 18:19:09 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by luna.archlinux.org (Postfix) with ESMTPS for ; Fri, 8 Jun 2018 18:19:09 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id E2429B1D81BE7 for ; Fri, 8 Jun 2018 18:19:07 +0000 (UTC) Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS for ; Fri, 8 Jun 2018 18:19:07 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id v13-v6so14258517wrp.13 for ; Fri, 08 Jun 2018 11:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=DR9UMdwsMoYzDi5uqHnxF0tI0dAeutAiV5UFELIev8g=; b=Pib0RF7AjzDdp4kbXJj66v5OylHBlQzkEJaGBhrS2Q8x6HZ3u4lCBjmxv37tk+h4vD /L9SvuTWKzOYGzLU5PkRW8FqfEM5+jJhpxcGfIrZtgFGPb59kwNO7np4vam8wV/P/QQr l1dygdn7vDvJHEhpXjU93F5bM0qaor7BugwIMd/OGDzueB4bLjoOBQCEcmKjAhglIlWD t/x6C6uU3xYkqfnx1FPWppcDt/tdMtYBr825mFo+uMRBF5aQbkhbQPzv7BQs95T6Q/om G0o3NZWUFra1svV3cPe1wwIq+9K8ZBL4Ha6g8WAmVMHwCz5BPnBj10tPDimkJOp82vvx ClPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DR9UMdwsMoYzDi5uqHnxF0tI0dAeutAiV5UFELIev8g=; b=tWnbGsuPOlvXqVOvnedpVL6Y+F24oSaGNyGdhKx4VVHz4TC+BH7RjVMAFn6hPA51eT M4b+zKL1g4dnLimq/woPAPRnPaVu2Zzkb/rnjhfJnS8yyopz57myfXg7TYssOlrxylvk XkN8frzboUPiSgU7nXL/aKwfzekS5m2Qx7ohcQSXE4mKG3t817jNKisz6Dn7AhwGoaF1 +2Cvpt3PBa1csQ30PeaPJIXkxeS2cPnvkhyXNARN2eCU+b6VpYfy6UUMrnHfGYtXs+Uz tVRutsvq5yNDaWeoyaS/1iUKnpos7gqtkfgZVjW/da5IB6WXvXx/2MBLbMfQ9Ga19gJo DVcQ== X-Gm-Message-State: APt69E2SaOnvuNolHh8cJQeCMDy6X7Xo4QoB2AnbWQumgEHllxr1QDZ3 fjXR8tOJIzdrsHETXplWJWfgqusO X-Google-Smtp-Source: ADUXVKIJNYD0K50gFjndESCJuJbyQT3TGSbsVSNLpOn5qXMDAaryQDRKK1fJBhr9ZJvbAgrXMr9s0A== X-Received: by 2002:adf:a982:: with SMTP id b2-v6mr5916703wrd.122.1528481947207; Fri, 08 Jun 2018 11:19:07 -0700 (PDT) Received: from Vinyl.localdomain (88-109-53-250.dynamic.dsl.as9105.com. [88.109.53.250]) by smtp.gmail.com with ESMTPSA id d7-v6sm38346375wrm.9.2018.06.08.11.19.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jun 2018 11:19:06 -0700 (PDT) From: morganamilo To: pacman-dev@archlinux.org Date: Fri, 8 Jun 2018 19:18:52 +0100 Message-Id: <20180608181859.20724-1-morganamilo@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [pacman-dev] [PATCH 0/7] Improve linting for makepkg X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Discussion list for pacman development Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" I recently did some data crunshing on AUR packages, trying to find ones that are formatted incorrectly, catching mistakes makepkg did not. I wrote up on the results here https://github.com/Morganamilo/go-srcinfo/issues/1. This patch should cover all the mistakes found and make is so that makepkg bails out duing the linting phase and users are forced to make more correct pkgbuilds. morganamilo (7): libmakepkg: disallow empty arch libmakepkg: stop printsrcinfo generating empty values libmakepkg: lint disallowed variables in package() libmakepkg: lint disallowed architecture specific variables libmakepkg: disallow using any as an architecture specific variable libmakepkg: add pkgbase to linted variables libmakepkg: disallow using 'any' with other arches scripts/libmakepkg/lint_pkgbuild/arch.sh.in | 14 +++- .../libmakepkg/lint_pkgbuild/variable.sh.in | 72 ++++++++++++++++++- scripts/libmakepkg/srcinfo.sh.in | 6 +- 3 files changed, 86 insertions(+), 6 deletions(-)