| Message ID | CAGRr6BH+HYa88RgTVO45vmLvsZgz-XEUukTXjamhDsLsD_gc=Q@mail.gmail.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On July 16, 2018 6:20:30 AM EDT, Antony Lee <anntzer.lee@gmail.com> wrote: >From 05c11d3e1a7fc0079fca4ccf3694a88a9d2d0146 Mon Sep 17 00:00:00 2001 >From: Antony Lee <anntzer.lee@gmail.com> >Date: Mon, 16 Jul 2018 12:02:56 +0200 >Subject: [PATCH] Set vim 'commentstring' option in >ftplugin/PKGBUILD.vim. > >This option enables, in particular, commenting plugings (e.g. >https://github.com/tomtom/tcomment_vim) to know how toggle comments on >PKGBUILDs. See FS#59321. > >Signed-off-by: Antony Lee <anntzer.lee@gmail.com> >--- > src/Makefile.am | 7 ++++++- > src/vim/ftplugin/PKGBUILD.vim | 4 ++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > create mode 100644 src/vim/ftplugin/PKGBUILD.vim > >diff --git a/src/Makefile.am b/src/Makefile.am >index 792da70..e756899 100644 >--- a/src/Makefile.am >+++ b/src/Makefile.am >@@ -14,11 +14,15 @@ bin_SCRIPTS = \ > bin_PROGRAMS = pacsort pactree > > vim_ftdetect_dir = $(vim_dir)/ftdetect >+vim_ftplugin_dir = $(vim_dir)/ftplugin > vim_syntax_dir = $(vim_dir)/syntax > > vim_ftdetect__DATA = \ > vim/ftdetect/PKGBUILD.vim > >+vim_ftplugin__DATA = \ >+ vim/ftplugin/PKGBUILD.vim >+ > vim_syntax__DATA = \ > vim/syntax/PKGBUILD.vim > >@@ -62,7 +66,8 @@ EXTRA_DIST = \ > rankmirrors.sh.in \ > updpkgsums.sh.in \ > vim/syntax/PKGBUILD.vim \ >- vim/ftdetect/PKGBUILD.vim >+ vim/ftdetect/PKGBUILD.vim \ >+ vim/ftplugin/PKGBUILD.vim > > # Files that should be removed, but which Automake does not know. > MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp >diff --git a/src/vim/ftplugin/PKGBUILD.vim >b/src/vim/ftplugin/PKGBUILD.vim >new file mode 100644 >index 0000000..cbb46a9 >--- /dev/null >+++ b/src/vim/ftplugin/PKGBUILD.vim >@@ -0,0 +1,4 @@ >+if exists("b:did_ftplugin") | finish | endif >+let b:did_ftplugin = 1 >+ >+setlocal commentstring=#\ %s >-- >2.18.0 Did you send this patch using `git send-email`? Can't seem to apply it.
I generated it with git send-email but then copy-pasted it manually to gmail, as I haven't set up proper interaction between git and gmail's 2FA. For completeness, this email also includes the patch (as `git show -p HEAD >foo.patch`) as an attachment. Antony On Thu, Aug 2, 2018 at 9:51 AM, Daniel M. Capella <polycitizen@gmail.com> wrote: > On July 16, 2018 6:20:30 AM EDT, Antony Lee <anntzer.lee@gmail.com> wrote: >> >> From 05c11d3e1a7fc0079fca4ccf3694a88a9d2d0146 Mon Sep 17 00:00:00 2001 >> From: Antony Lee <anntzer.lee@gmail.com> >> Date: Mon, 16 Jul 2018 12:02:56 +0200 >> Subject: [PATCH] Set vim 'commentstring' option in ftplugin/PKGBUILD.vim. >> >> This option enables, in particular, commenting plugings (e.g. >> https://github.com/tomtom/tcomment_vim) to know how toggle comments on >> PKGBUILDs. See FS#59321. >> >> Signed-off-by: Antony Lee <anntzer.lee@gmail.com> >> --- >> src/Makefile.am | 7 ++++++- >> src/vim/ftplugin/PKGBUILD.vim | 4 ++++ >> 2 files changed, 10 insertions(+), 1 deletion(-) >> create mode 100644 src/vim/ftplugin/PKGBUILD.vim >> >> diff --git a/src/Makefile.am b/src/Makefile.am >> index 792da70..e756899 100644 >> --- a/src/Makefile.am >> +++ b/src/Makefile.am >> @@ -14,11 +14,15 @@ bin_SCRIPTS = \ >> bin_PROGRAMS = pacsort pactree >> >> vim_ftdetect_dir = $(vim_dir)/ftdetect >> +vim_ftplugin_dir = $(vim_dir)/ftplugin >> vim_syntax_dir = $(vim_dir)/syntax >> >> vim_ftdetect__DATA = \ >> vim/ftdetect/PKGBUILD.vim >> >> +vim_ftplugin__DATA = \ >> + vim/ftplugin/PKGBUILD.vim >> + >> vim_syntax__DATA = \ >> vim/syntax/PKGBUILD.vim >> >> @@ -62,7 +66,8 @@ EXTRA_DIST = \ >> rankmirrors.sh.in \ >> updpkgsums.sh.in \ >> vim/syntax/PKGBUILD.vim \ >> - vim/ftdetect/PKGBUILD.vim >> + vim/ftdetect/PKGBUILD.vim \ >> + vim/ftplugin/PKGBUILD.vim >> >> # Files that should be removed, but which Automake does not know. >> MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp >> diff --git a/src/vim/ftplugin/PKGBUILD.vim b/src/vim/ftplugin/PKGBUILD.vim >> new file mode 100644 >> index 0000000..cbb46a9 >> --- /dev/null >> +++ b/src/vim/ftplugin/PKGBUILD.vim >> @@ -0,0 +1,4 @@ >> +if exists("b:did_ftplugin") | finish | endif >> +let b:did_ftplugin = 1 >> + >> +setlocal commentstring=#\ %s >> >> > Did you send this patch using `git send-email`? Can't seem to apply it. > -- > Best, > polyzen > <div dir="ltr">I generated it with git send-email but then copy-pasted it manually to gmail, as I haven't set up proper interaction between git and gmail's 2FA.<div>For completeness, this email also includes the patch (as `git show -p HEAD >foo.patch`) as an attachment.</div><div>Antony</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 2, 2018 at 9:51 AM, Daniel M. Capella <span dir="ltr"><<a href="mailto:polycitizen@gmail.com" target="_blank">polycitizen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div class="h5"><div class="gmail_quote">On July 16, 2018 6:20:30 AM EDT, Antony Lee <<a href="mailto:anntzer.lee@gmail.com" target="_blank">anntzer.lee@gmail.com</a>> wrote:<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <pre class="m_-2932655993199056212k9mail">From 05c11d3e1a7fc0079fca4ccf3694a8<wbr>8a9d2d0146 Mon Sep 17 00:00:00 2001<br>From: Antony Lee <<a href="mailto:anntzer.lee@gmail.com" target="_blank">anntzer.lee@gmail.com</a>><br>Date: Mon, 16 Jul 2018 12:02:56 +0200<br>Subject: [PATCH] Set vim 'commentstring' option in ftplugin/PKGBUILD.vim.<br><br>This option enables, in particular, commenting plugings (e.g.<br><a href="https://github.com/tomtom/tcomment_vim)" target="_blank">https://github.com/tomtom/<wbr>tcomment_vim)</a> to know how toggle comments on<br>PKGBUILDs. See FS#59321.<br><br>Signed-off-by: Antony Lee <<a href="mailto:anntzer.lee@gmail.com" target="_blank">anntzer.lee@gmail.com</a>><br>---<br> src/Makefile.am | 7 ++++++-<br> src/vim/ftplugin/PKGBUILD.vim | 4 ++++<br> 2 files changed, 10 insertions(+), 1 deletion(-)<br> create mode 100644 src/vim/ftplugin/PKGBUILD.vim<br><br>diff --git a/src/Makefile.am b/src/Makefile.am<br>index 792da70..e756899 100644<br>--- a/src/Makefile.am<br>+++ b/src/Makefile.am<br>@@ -14,11 +14,15 @@ bin_SCRIPTS = \<br> bin_PROGRAMS = pacsort pactree<br><br> vim_ftdetect_dir = $(vim_dir)/ftdetect<br>+vim_ftplugin_dir = $(vim_dir)/ftplugin<br> vim_syntax_dir = $(vim_dir)/syntax<br><br> vim_ftdetect__DATA = \<br> vim/ftdetect/PKGBUILD.vim<br><br>+vim_ftplugin__DATA = \<br>+ vim/ftplugin/PKGBUILD.vim<br>+<br> vim_syntax__DATA = \<br> vim/syntax/PKGBUILD.vim<br><br>@@ -62,7 +66,8 @@ EXTRA_DIST = \<br> <a href="http://rankmirrors.sh.in" target="_blank">rankmirrors.sh.in</a> \<br> <a href="http://updpkgsums.sh.in" target="_blank">updpkgsums.sh.in</a> \<br> vim/syntax/PKGBUILD.vim \<br>- vim/ftdetect/PKGBUILD.vim<br>+ vim/ftdetect/PKGBUILD.vim \<br>+ vim/ftplugin/PKGBUILD.vim<br><br> # Files that should be removed, but which Automake does not know.<br> MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp<br>diff --git a/src/vim/ftplugin/PKGBUILD.<wbr>vim b/src/vim/ftplugin/PKGBUILD.<wbr>vim<br>new file mode 100644<br>index 0000000..cbb46a9<br>--- /dev/null<br>+++ b/src/vim/ftplugin/PKGBUILD.<wbr>vim<br>@@ -0,0 +1,4 @@<br>+if exists("b:did_ftplugin") | finish | endif<br>+let b:did_ftplugin = 1<br>+<br>+setlocal commentstring=#\ %s</pre></blockquote></div><br clear="all"></div></div>Did you send this patch using `git send-email`? Can't seem to apply it.<span class="HOEnZb"><font color="#888888"><br> -- <br> Best,<br> polyzen</font></span></div></blockquote></div><br></div> commit 05c11d3e1a7fc0079fca4ccf3694a88a9d2d0146 Author: Antony Lee <anntzer.lee@gmail.com> Date: Mon Jul 16 12:02:56 2018 +0200 Set vim 'commentstring' option in ftplugin/PKGBUILD.vim. This option enables, in particular, commenting plugings (e.g. https://github.com/tomtom/tcomment_vim) to know how toggle comments on PKGBUILDs. See FS#59321. Signed-off-by: Antony Lee <anntzer.lee@gmail.com> diff --git a/src/Makefile.am b/src/Makefile.am index 792da70..e756899 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,11 +14,15 @@ bin_SCRIPTS = \ bin_PROGRAMS = pacsort pactree vim_ftdetect_dir = $(vim_dir)/ftdetect +vim_ftplugin_dir = $(vim_dir)/ftplugin vim_syntax_dir = $(vim_dir)/syntax vim_ftdetect__DATA = \ vim/ftdetect/PKGBUILD.vim +vim_ftplugin__DATA = \ + vim/ftplugin/PKGBUILD.vim + vim_syntax__DATA = \ vim/syntax/PKGBUILD.vim @@ -62,7 +66,8 @@ EXTRA_DIST = \ rankmirrors.sh.in \ updpkgsums.sh.in \ vim/syntax/PKGBUILD.vim \ - vim/ftdetect/PKGBUILD.vim + vim/ftdetect/PKGBUILD.vim \ + vim/ftplugin/PKGBUILD.vim # Files that should be removed, but which Automake does not know. MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp diff --git a/src/vim/ftplugin/PKGBUILD.vim b/src/vim/ftplugin/PKGBUILD.vim new file mode 100644 index 0000000..cbb46a9 --- /dev/null +++ b/src/vim/ftplugin/PKGBUILD.vim @@ -0,0 +1,4 @@ +if exists("b:did_ftplugin") | finish | endif +let b:did_ftplugin = 1 + +setlocal commentstring=#\ %s
diff --git a/src/Makefile.am b/src/Makefile.am index 792da70..e756899 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -14,11 +14,15 @@ bin_SCRIPTS = \ bin_PROGRAMS = pacsort pactree vim_ftdetect_dir = $(vim_dir)/ftdetect +vim_ftplugin_dir = $(vim_dir)/ftplugin vim_syntax_dir = $(vim_dir)/syntax vim_ftdetect__DATA = \ vim/ftdetect/PKGBUILD.vim +vim_ftplugin__DATA = \ + vim/ftplugin/PKGBUILD.vim + vim_syntax__DATA = \ vim/syntax/PKGBUILD.vim @@ -62,7 +66,8 @@ EXTRA_DIST = \ rankmirrors.sh.in \ updpkgsums.sh.in \ vim/syntax/PKGBUILD.vim \ - vim/ftdetect/PKGBUILD.vim + vim/ftdetect/PKGBUILD.vim \ + vim/ftplugin/PKGBUILD.vim # Files that should be removed, but which Automake does not know. MOSTLYCLEANFILES = $(OURSCRIPTS) $(OURFILES) *.tmp diff --git a/src/vim/ftplugin/PKGBUILD.vim b/src/vim/ftplugin/PKGBUILD.vim new file mode 100644 index 0000000..cbb46a9 --- /dev/null +++ b/src/vim/ftplugin/PKGBUILD.vim @@ -0,0 +1,4 @@ +if exists("b:did_ftplugin") | finish | endif +let b:did_ftplugin = 1 + +setlocal commentstring=#\ %s