| Message ID | CAKJAW0YnJz5wPus2hFiOOAfTiz1Wf3dOjF180-w+27kCoDXhHA@mail.gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/1] TESTING: Adding 2 required packages in the documentation file. Replacing MySQL with SQLite in the comment | expand |
Dear Nodiv, On Tue, 06 Mar 2018 at 03:38:08, Nodiv Byzero wrote: > --- > TESTING | 2 +- > schema/Makefile | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > [...] Thank you for working on this! Something must have gone wrong when you submitted the patch, though. It looks like tabs were replaced by spaces and thus, the patch cannot be applied as-is. I recommend using git-send-email(1). I would also prefer to have two separate commits (with separate commit messages) for the two issues that are fixed. Thanks! Regards, Lukas
Thank you Lukas for review. I'll fix spaces issue and re-submit in two new commits. Cheers, Nodiv On Sat, Mar 10, 2018 at 7:55 AM, Lukas Fleischer <lfleischer@archlinux.org> wrote: > Dear Nodiv, > > On Tue, 06 Mar 2018 at 03:38:08, Nodiv Byzero wrote: >> --- >> TESTING | 2 +- >> schema/Makefile | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> [...] > > Thank you for working on this! Something must have gone wrong when you > submitted the patch, though. It looks like tabs were replaced by spaces > and thus, the patch cannot be applied as-is. I recommend using > git-send-email(1). > > I would also prefer to have two separate commits (with separate commit > messages) for the two issues that are fixed. > > Thanks! > > Regards, > Lukas
diff --git a/TESTING b/TESTING index d2c97d9..9613314 100644 --- a/TESTING +++ b/TESTING @@ -11,7 +11,7 @@ INSTALL. 2) Install php and necessary modules: - # pacman -S php php-sqlite sqlite + # pacman -S php php-sqlite sqlite words fortune-mod 3) Prepare the testing database: diff --git a/schema/Makefile b/schema/Makefile index e0448ad..62d0856 100644 --- a/schema/Makefile +++ b/schema/Makefile @@ -3,6 +3,7 @@ aur-schema-sqlite.sql: aur-schema.sql -e 's/ ENGINE = InnoDB//' \ -e 's/ [A-Z]* UNSIGNED NOT NULL AUTO_INCREMENT/ INTEGER NOT NULL/' \ -e 's/([0-9, ]*) UNSIGNED / UNSIGNED /' \ + -e 's/ MySQL / SQLite /' \ $< >$@ clean: