diff mbox

Update copyright year. Four years just passed in the blink of an eye. :)

Message ID 20180501191238.31679-1-eschwartz@archlinux.org
State Accepted, archived
Headers show

Commit Message

Eli Schwartz May 1, 2018, 7:12 p.m. UTC 
Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
---
 web/template/cgit/footer.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lukas Fleischer May 10, 2018, 7:30 a.m. UTC | #1 
On Tue, 01 May 2018 at 21:12:38, Eli Schwartz wrote:
> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
> ---
>  web/template/cgit/footer.html | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> [...]

Pushed to pu (with a slightly different commit message), thanks!

I wonder whether we can easily auto-generate this date in the footer to
avoid missing future updates?
Eli Schwartz May 10, 2018, 1:57 p.m. UTC | #2 
On 05/10/2018 03:30 AM, Lukas Fleischer wrote:
> On Tue, 01 May 2018 at 21:12:38, Eli Schwartz wrote:
>> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
>> ---
>>  web/template/cgit/footer.html | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> [...]
> 
> Pushed to pu (with a slightly different commit message), thanks!
> 
> I wonder whether we can easily auto-generate this date in the footer to
> avoid missing future updates?

In pacman, we'd just run `make update-copyright` to update this in many
files in the codebase. But it does need remembering.

We already autogenerate the date for the main aurweb interface:

https://git.archlinux.org/aurweb.git/tree/web/template/footer.php#n8

__('Copyright %s 2004-%d aurweb Development Team.', '&copy;', date('Y'))

cgit is different since we can only use HTML.
Lukas Fleischer May 10, 2018, 4:45 p.m. UTC | #3 
On Thu, 10 May 2018 at 15:57:46, Eli Schwartz wrote:
> In pacman, we'd just run `make update-copyright` to update this in many
> files in the codebase. But it does need remembering.

That is a good thing if there are multiple locations to update but it
does not really help if there only is a single spot.

> 
> We already autogenerate the date for the main aurweb interface:
> 
> https://git.archlinux.org/aurweb.git/tree/web/template/footer.php#n8
> 
> __('Copyright %s 2004-%d aurweb Development Team.', '&copy;', date('Y'))
> 
> cgit is different since we can only use HTML.

Yeah. We could add an intermediate step to generate the HTML footer but
I don't think the benefits would outweigh the additional maintenance
burden. So let's keep it as-is for now...

Regards,
Lukas
diff mbox

Patch

diff --git a/web/template/cgit/footer.html b/web/template/cgit/footer.html
index 36e0f1b..6ceec28 100644
--- a/web/template/cgit/footer.html
+++ b/web/template/cgit/footer.html
@@ -1,6 +1,6 @@ 
 <div id="footer">
 	<p>
-		Copyright &copy; 2004-2014 aurweb Development Team &ndash;
+		Copyright &copy; 2004-2018 aurweb Development Team &ndash;
 		<strong>AUR packages are user produced content. Any use of the provided files is at your own risk.</strong>
 	</p>
 </div>