From patchwork Fri Sep 9 18:06:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michel Alexandre Salim X-Patchwork-Id: 2080 Return-Path: Delivered-To: patchwork@archlinux.org Received: from mail.archlinux.org [2a01:4f9:c010:3052::1] by patchwork.archlinux.org with IMAP (fetchmail-6.4.33) for (single-drop); Fri, 09 Sep 2022 18:06:56 +0000 (UTC) Received: from mail.archlinux.org by mail.archlinux.org with LMTP id vObLK7+AG2PwUggAK+/4rw (envelope-from ) for ; Fri, 09 Sep 2022 18:06:55 +0000 Received: from lists.archlinux.org (lists.archlinux.org [95.217.236.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.archlinux.org (Postfix) with ESMTPS id 2995514426ED; Fri, 9 Sep 2022 18:06:54 +0000 (UTC) Received: from mailman3.archlinux.org (unknown [10.0.0.37]) by lists.archlinux.org (Postfix) with ESMTP id 56371148802F; Fri, 9 Sep 2022 18:06:52 +0000 (UTC) Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by lists.archlinux.org (Postfix) with ESMTPS id 23497148802A for ; Fri, 9 Sep 2022 18:06:45 +0000 (UTC) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4MPP826DxDz9sQM for ; Fri, 9 Sep 2022 20:06:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=michel-slm.name; s=MBO0001; t=1662746802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=8UNl9XLtZpYAltnpG2gFrUVz7DRtjId77fmX5J9SW28=; b=eVxDbTNQGBkdrv++Oa+889nDHnbmh4qLjsX8o4PeVVMzVF85fyM3SsvmDtzOEmGwsbGrW0 lLbi+ue0mT8Txksdm22kJaDYDciXi/iHadb4FpZkL5KFAileulsHYIDIPRzYLlxEaE+w8m 0Ee7wfFpu8RlqtDKfcGhweuDr9MpBVLI2IjZYKAAqIyouHKM+EuTwe1SIXowUQORV3h6Ti jgknZ/aMEygIbcUkQ3OGLsfP4zwfhhy5YHtJPB62kTcsXWvyxLzFNsDHVM5Pwh+bs6XGmn fcu7370EGI0CMs8mi8P4efQovfN22iyxpTNzgrPw6Bg6NjFO/VrxTF2b5AwTBg== Date: Fri, 9 Sep 2022 13:06:39 -0500 From: Michel Alexandre Salim To: Arch Projects mailing list Subject: [PATCH] archlinux-keyring: harcode using bash as make's shell Message-ID: MIME-Version: 1.0 Content-Disposition: inline Message-ID-Hash: HIS5X5VWWJYI4CZIZBBPHV54UXVG7LQR X-Message-ID-Hash: HIS5X5VWWJYI4CZIZBBPHV54UXVG7LQR X-MailFrom: michel@michel-slm.name X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.5 Precedence: list List-Id: Arch Linux projects development discussion Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Spamd-Result: default: False [-3.71 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[michel-slm.name,none]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; RCVD_IN_DNSWL_LOW(-0.20)[2001:67c:2050:0:465::201:received,2001:67c:2050:b231:465::102:received]; MAILLIST(-0.20)[mailman]; R_DKIM_ALLOW(-0.20)[michel-slm.name:s=MBO0001]; R_SPF_ALLOW(-0.20)[+ip4:95.217.236.249:c]; RCVD_IN_DNSWL_MED(-0.20)[95.217.236.249:from]; HAS_LIST_UNSUB(-0.01)[]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[arch-projects@lists.archlinux.org]; NEURAL_HAM(-0.00)[-1.000]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:+,4:~]; ASN(0.00)[asn:24940, ipnet:95.217.0.0/16, country:DE]; RCVD_COUNT_THREE(0.00)[4]; HAS_ATTACHMENT(0.00)[]; FROM_NEQ_ENVFROM(0.00)[michel@michel-slm.name,arch-projects-bounces@lists.archlinux.org]; TO_DN_ALL(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; DKIM_TRACE(0.00)[michel-slm.name:+]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER_MAILLIST(0.00)[] X-Rspamd-Server: mail.archlinux.org X-Rspamd-Queue-Id: 2995514426ED Authentication-Results: mail.archlinux.org; dkim=pass header.d=michel-slm.name header.s=MBO0001 header.b=eVxDbTNQ; dmarc=pass (policy=none) header.from=michel-slm.name; spf=pass (mail.archlinux.org: domain of arch-projects-bounces@lists.archlinux.org designates 95.217.236.249 as permitted sender) smtp.mailfrom=arch-projects-bounces@lists.archlinux.org Dear archlinux-keyring maintainers, Please find attached a patch to make the latest archlinux-keyring release (20220831) build on Debian/Ubuntu, where the default shell is Dash (and the build environment enforces this by passing SHELL=dash). Makefile seems to have acquired some Bash-isms ({} expansion) in 0831 that was not in 0727, and since the usage makes sense, hardcoding the shell to be bash would allow this to work without having to override Debian and Ubuntu builds for the affected targets. Thanks, --- a/Makefile +++ b/Makefile @@ -1,3 +1,4 @@ +SHELL = /bin/bash PREFIX ?= /usr/local KEYRING_TARGET_DIR ?= $(PREFIX)/share/pacman/keyrings/ SCRIPT_TARGET_DIR ?= $(PREFIX)/bin/