diff mbox

[devtools] makechrootpkg: load compression-related vars, mostly to allow multi-core compression

Message ID 44a25fe9-4654-5cc2-51f2-652d50ddf2ce@piater.name
State Rejected
Headers show

Commit Message

Bennett Piater May 11, 2017, 12:51 p.m. UTC
Compressing large packages on a single core takes much longer than
necessary, so loading these vars would save a lot of time.

---
 makechrootpkg.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Evangelos Foutras May 11, 2017, 2:04 p.m. UTC | #1
On 11 May 2017 at 15:51, Bennett Piater <bennett@piater.name> wrote:

> Compressing large packages on a single core takes much longer than
> necessary, so loading these vars would save a lot of time.
>

This would probably break delta packages, so it's a no-go.

https://lists.archlinux.org/pipermail/arch-general/2014-December/038074.html
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 11 May 2017 at 15:51, Bennett Piater <span dir="ltr">&lt;<a href="mailto:bennett@piater.name" target="_blank">bennett@piater.name</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Compressing large packages on a single core takes much longer than<br>
necessary, so loading these vars would save a lot of time.<br></blockquote><div><br></div><div>This would probably break delta packages, so it&#39;s a no-go.</div><div><br></div><div><a href="https://lists.archlinux.org/pipermail/arch-general/2014-December/038074.html">https://lists.archlinux.org/pipermail/arch-general/2014-December/038074.html</a><br></div></div></div></div>
diff mbox

Patch

diff --git a/makechrootpkg.in b/makechrootpkg.in
index 72b7eb7..69b2122 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -91,7 +91,7 @@  load_vars() {
         [[ -f $makepkg_conf ]] || return 1
 -       for var in {SRC,SRCPKG,PKG,LOG}DEST MAKEFLAGS PACKAGER; do
+       for var in {SRC,SRCPKG,PKG,LOG}DEST MAKEFLAGS PACKAGER
COMPRESS{{G,X,LR,}Z,BZ2,LZO}; do
                [[ -z ${!var:-} ]] && eval $(grep "^${var}="
"$makepkg_conf")
        done
 -- 2.12.2