From patchwork Sun Apr 19 21:01:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov via arch-projects X-Patchwork-Id: 1599 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 274B7184A3256 for ; Sun, 19 Apr 2020 21:02:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on apollo.archlinux.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1, MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.4 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Sun, 19 Apr 2020 21:02:04 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id A18DB1B1A6F992; Sun, 19 Apr 2020 21:02:01 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [5.9.250.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: luna) by orion.archlinux.org (Postfix) with ESMTPSA id 31B3E1B1A6F98B; Sun, 19 Apr 2020 21:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=orion; t=1587330121; bh=ruNJogIaXnT10UwCQIhxXRNuUmLRi9PBqD7I+yopMak=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc; b=sak3lGbqwFWuNV9VCUNWft3di8LuL9OzUgVOVk3WWrwU3V+sL7TKqRpQZ6MoQ4gJE XaiANmQvwUAjwD8ugEKgoXxY9N24oSNpefgnhAcWiCsushUUNbyCBTVspMDE3quexq qPwNzk0D8XliUm3lpXO0gO325aXFCbbWsma/R74i+qICsKENeMFRLjwNd0cED3eLlI P1aDQE5T0bxtGM0GF6Y6YKQ+78+mMeDRX/uI0Nq3qe6Ou5yjlR2PJt/V351Jl7YJ77 R8ADJ20tm+BmZpE6cH6FHT/8T7GgcczrrcD1B5vfgCAwQMTiY5XbQpWWcJTpxff0JI I4OfBdr0VQuw6vK/x966vLV8ajFqnmHatIEwz7VaMO6cgyVS9q29Bc+74YSpSosWxs 3ZbMil5bGppbu3KUn/+GQfBIytGrBOndMoWXoEEVzLtfa0SCPnSKyyI/jUw3z8fC9m S8fdp8EjHqoujl4KYjg+7vC0jeFbJfdbXJpgBkZFc+u5lU1KBwr8odz5IaLCi8X7VL 9tXFna1ifC8ppaDWyY5xDL5b+6/8tNNrg0dWu098/rNMAAEvGsdXGS0aWnhg0PPd/B NaX/9KtrKTtrQECobwNM8YIeBpjuI/cxBSsBXRKBqlQk9DU/Hwtqd/2UwCSR0bo63d 2hsYm/UlDaymzAefpGm6Y/qI= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 159822A94F; Sun, 19 Apr 2020 21:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1587330121; bh=ruNJogIaXnT10UwCQIhxXRNuUmLRi9PBqD7I+yopMak=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc; b=e34MK9MbafG8R/V/M3q7eRe47KiKlM0RFHgpEzSCR/t+Mjo2CwUkcL5VFk0oreMOC GNxoH4lV4cGrIkH78pCMciC8O9aerbhNS0WARufHG+iOpimVWvmYtkYzgIpYpCv46V Btv75yveeVGYtiSfgt8ra9pLhbBzCgx0x6kQJ0XevSPnMRajdudpfTDiQ/47Jl8dGy vI8i8oLPpJxTs+C7/9pKPTSAcBi3/nX/0r51KGkZJQkjQ61CZnRquL43r5Jpy6G4D9 9QwtekoLRgrngByibsCHhkSO0AWylGR8c2ginPWdevB5APrrvURee0HeN7Ma0aDXRK avI8istVL8H3f++nVmubSCct2KXLATsYyic45IU0Di0u2B2Js3IMgYJFv/zND6bXJk H5QVhFwjfC+Ub2+LkcHKvCdvl7yxih8+DHEw2yGggvFsJQjZ6/FE6u9TIU44+zTiTR /fdtqO7C5MxdBnEV/2fCDyjCqJ9tkFVwEcQhsgauGyR2yHeYrjH1MOVRIp7kPInvss monOn5dCzOTZzQIYeYOv8mjWh7CwsLf0h6FaI4UKMTzn5Hr9zP0/yNTtqP/x9BvDFF ZoUtuR0FD/kZE8IlNIOUoORyCv2Rt64IuEdwgpVmntnawmbmGkyjgIb9UE3uC8NA81 Nf+CkJ1MiMUoa4h+IxswO7DY= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id E53AC2A93F for ; Sun, 19 Apr 2020 21:01:57 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Sun, 19 Apr 2020 21:01:57 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 9C4851B1A6F985; Sun, 19 Apr 2020 21:01:56 +0000 (UTC) Received: from didactylos.attlocal.net (unknown [IPv6:2600:1700:57f0:ca20:763a:c795:fcf6:91ea]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: eschwartz) by orion.archlinux.org (Postfix) with ESMTPSA id 096D91B1A6F984; Sun, 19 Apr 2020 21:01:55 +0000 (UTC) To: arch-projects@archlinux.org Date: Sun, 19 Apr 2020 17:01:43 -0400 Message-Id: <20200419210143.1294353-1-eschwartz@archlinux.org> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 Subject: [arch-projects] [namcap] [PATCH] silently skip over packages of type ${pkgbase}-debug X-BeenThere: arch-projects@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Arch Linux projects development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eli Schwartz via arch-projects Reply-To: Arch Linux projects development discussion Cc: Eli Schwartz Errors-To: arch-projects-bounces@archlinux.org Sender: "arch-projects" These produce many false positives, for example ELF warnings for split debug info. Under no circumstances do we want to claim there are any errors here, since makepkg autogenerates the package and we presume it's always right. Issues will always occur in the main package(s) only. Signed-off-by: Eli Schwartz --- Namcap/package.py | 2 +- namcap.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Namcap/package.py b/Namcap/package.py index 2da5b1d..86129fe 100644 --- a/Namcap/package.py +++ b/Namcap/package.py @@ -209,7 +209,7 @@ def load_from_pkgbuild(path): return ret def load_from_alpm(pmpkg): - variables = ['name', 'version', 'conflicts', 'url', + variables = ['base', 'name', 'version', 'conflicts', 'url', 'depends', 'desc', 'files', 'groups', 'has_scriptlet', 'size', 'licenses', 'optdepends', 'packager', 'provides', 'replaces'] diff --git a/namcap.py b/namcap.py index a7f532a..dcf06f7 100755 --- a/namcap.py +++ b/namcap.py @@ -86,6 +86,10 @@ def process_realpackage(package, modules): return 1 pkginfo = Namcap.package.load_from_tarball(package) + + if pkginfo['name'] == pkginfo['base'] + '-debug': + # there are no errors -- this is a debug package autogenerated by makepkg + return 0 # Loop through each one, load them apply if possible for i in modules: rule = get_modules()[i]()