From patchwork Wed Apr 17 11:16:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov via arch-projects X-Patchwork-Id: 1083 X-Patchwork-Delegate: jelle@vdwaa.nl Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 762CFD5F1FDC for ; Wed, 17 Apr 2019 11:17:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on apollo X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00=-1, DKIMWL_WL_HIGH=-0.024,DKIM_SIGNED=0.1,DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3, T_DMARC_POLICY_NONE=0.01 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-BL-Results: [127.0.9.2] Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Wed, 17 Apr 2019 11:17:28 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id AE3D611FC299A5; Wed, 17 Apr 2019 11:17:26 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [5.9.250.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Wed, 17 Apr 2019 11:17:26 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 79E1A20EBC; Wed, 17 Apr 2019 11:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=archlinux.org; s=luna2; t=1555499846; bh=XRQoDCIntNnJZ+pVx6WYP+unv5hukkN+iXDemvN23Fo=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc; b=nWavjUi7Ac3vCAb5iTN2vozqcsdZ3r4cUoh4DKNm/mzELxQJvkRbso0cb9e3pIonu H7rgjv7ImgWlYcTcS8YnbgPFqftDmoGf+4tG42Tw7/Qwfny2qbMQB7u0XvSoi693XK Hapi29ykpB47+sDTg3UR1LRo+psD4NE8dPDpHldRnZ5/dkBHdKl3yqkt3RtA0aWyuT GwJvjM6q/n0N4DK8OKIEnakMtO5rBMgy3nWtCp80yBbQ2DuBEYI9vaek3Wlpwf9EgK czVAGUQ1cuJZvB0So3VhbjvxQI7ileNG3MvynP8WNgwzfpwYEZcWGpjrBRgQ7QpsNR K/hIwi+ROZZN3ATT7nwQ0FmR6/KiOpYxmkd/k531J1puCItnRPrF2i4i0nIzIVhfyO Ocjli8m+RzQUMqyuIIz3czVHgpM6W4k3wbtXxnq94WqVdXkZDKRU431XqxyMMgvYQh JEam8drmi4bXKhNIu0xSCnVKQ5GadVEzJ3SCveUnl5mQc4bkOiQ8/q113YfP1fPXqt DrYKUw2XttH8AeLHDaf7k4s2tQDKJeDbqrLH+/ohRkirjSeXj85zRJmGlp7CW/j6/w UI4tETqulXVtqrb8G4gd+FNrFsrVZOQzgun8IY7Y+7BJytWlDd1SsU9n7w/jQ/ZhCx f4DdCIxjL9WsFzDGrdrrn2Xc= Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id B420E20EB9 for ; Wed, 17 Apr 2019 11:17:22 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by luna.archlinux.org (Postfix) with ESMTPS for ; Wed, 17 Apr 2019 11:17:22 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 4408F11FC299A1 for ; Wed, 17 Apr 2019 11:17:18 +0000 (UTC) Received: from szilassi.eckner.net (szilassi.eckner.net [IPv6:2a03:4000:2a:1bc::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS for ; Wed, 17 Apr 2019 11:17:18 +0000 (UTC) Received-SPF: none (Address does not pass the Sender Policy Framework) SPF=HELO; sender=nlopc43.ioq.uni-jena.de; remoteip=::ffff:141.35.50.156; remotehost=nlopc43.ioq.uni-jena.de; helo=nlopc43.ioq.uni-jena.de; receiver=szilassi.eckner.net; Received-SPF: fail (Address does not pass the Sender Policy Framework) SPF=MAILFROM; sender=arch@eckner.net; remoteip=::ffff:141.35.50.156; remotehost=nlopc43.ioq.uni-jena.de; helo=nlopc43.ioq.uni-jena.de; receiver=szilassi.eckner.net; Received: from nlopc43.ioq.uni-jena.de (nlopc43.ioq.uni-jena.de [::ffff:141.35.50.156]) (AUTH: PLAIN erich@eckner.net, ) by szilassi.eckner.net with ESMTPSA id 0000000000820002.000000005CB70B3C.000033B1; Wed, 17 Apr 2019 13:17:16 +0200 To: arch-projects@archlinux.org Date: Wed, 17 Apr 2019 13:16:36 +0200 Message-Id: <20190417111635.28490-1-arch@eckner.net> X-Mailer: git-send-email 2.21.0 Mime-Version: 1.0 Received-SPF: fail (Address does not pass the Sender Policy Framework) SPF=FROM; sender=arch@eckner.net; remoteip=::ffff:141.35.50.156; remotehost=nlopc43.ioq.uni-jena.de; helo=nlopc43.ioq.uni-jena.de; receiver=szilassi.eckner.net; X-Mime-Autoconverted: from 8bit to 7bit by courier 1.0 Subject: [arch-projects] [devtools] [PATCH] is_same_fs() in lib/archroot.sh should use $1 and $2, not $1 and $1 X-BeenThere: arch-projects@archlinux.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Arch Linux projects development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: arch--- via arch-projects Reply-To: Arch Linux projects development discussion Cc: arch@eckner.net, Erich Eckner Errors-To: arch-projects-bounces@archlinux.org Sender: "arch-projects" From: Erich Eckner The old behaviour would always evaluate to true - this is certainly not what that function should do. Signed-off-by: Erich Eckner --- lib/archroot.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/archroot.sh b/lib/archroot.sh index f2796034..2c03c827 100644 --- a/lib/archroot.sh +++ b/lib/archroot.sh @@ -42,7 +42,7 @@ is_subvolume() { # return : whether $path_a and $path_b are on the same filesystem ## is_same_fs() { - [[ "$(stat -c %d "$1")" == "$(stat -c %d "$1")" ]] + [[ "$(stat -c %d "$1")" == "$(stat -c %d "$2")" ]] } ##