| Message ID | 20181202183335.28016-1-michael.straube@posteo.de |
|---|---|
| State | New |
| Headers | show |
| Series | [namcap] namcap-tags: Add back missing dependency reason tags (FS#56898) | expand |
On 12/2/18 1:33 PM, Michael Straube via arch-projects wrote: > There are two missing tags that are needed in rules added (back) in > commit e385ac93a354 (Restore and refactor accidentally removed tests). > Add back the missing tags. > > Signed-off-by: Michael Straube <michael.straube@posteo.de> > --- > namcap-tags | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/namcap-tags b/namcap-tags > index 17b9506..70dabb2 100644 > --- a/namcap-tags > +++ b/namcap-tags > @@ -101,6 +101,8 @@ depends-by-namcap-sight depends=(%s) :: Depends as namcap sees them: depends=(%s > dconf-needed-for-glib-schemas :: needed for glib schemas > glib2-needed-for-gio-modules :: needed for GIO modules > hicolor-icon-theme-needed-for-hicolor-dir :: needed for hicolor theme hierarchy > +shared-mime-info-needed :: needed for update-mime-database > +desktop-file-utils-needed :: needed for update-desktop-database > kdebase-runtime-needed %s :: needed for programs %s > java-runtime-needed %s :: found class files %s > libraries-needed %s %s :: libraries %s needed in files %s Huh, why do these tests even exist? The fact that we have hooks for them now, means that we never need to run either command at all. Applications that need a desktop or mime database will already depend on the relevant package, and packages that merely happen to be a provider of such files should not care whether or not you have other applications that can make use of them. We don't even need to use NeedsTargets, so it doesn't matter when the hook runs. It can be run in the future at any time.
Am 02.12.18 um 20:34 schrieb Eli Schwartz via arch-projects: > On 12/2/18 1:33 PM, Michael Straube via arch-projects wrote: >> There are two missing tags that are needed in rules added (back) in >> commit e385ac93a354 (Restore and refactor accidentally removed tests). >> Add back the missing tags. >> >> Signed-off-by: Michael Straube <michael.straube@posteo.de> >> --- >> namcap-tags | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/namcap-tags b/namcap-tags >> index 17b9506..70dabb2 100644 >> --- a/namcap-tags >> +++ b/namcap-tags >> @@ -101,6 +101,8 @@ depends-by-namcap-sight depends=(%s) :: Depends as namcap sees them: depends=(%s >> dconf-needed-for-glib-schemas :: needed for glib schemas >> glib2-needed-for-gio-modules :: needed for GIO modules >> hicolor-icon-theme-needed-for-hicolor-dir :: needed for hicolor theme hierarchy >> +shared-mime-info-needed :: needed for update-mime-database >> +desktop-file-utils-needed :: needed for update-desktop-database >> kdebase-runtime-needed %s :: needed for programs %s >> java-runtime-needed %s :: found class files %s >> libraries-needed %s %s :: libraries %s needed in files %s > > Huh, why do these tests even exist? The fact that we have hooks for them > now, means that we never need to run either command at all. Applications > that need a desktop or mime database will already depend on the relevant > package, and packages that merely happen to be a provider of such files > should not care whether or not you have other applications that can make > use of them. > > We don't even need to use NeedsTargets, so it doesn't matter when the > hook runs. It can be run in the future at any time. > I was also wondering and do not know why these tests were added (back).
diff --git a/namcap-tags b/namcap-tags index 17b9506..70dabb2 100644 --- a/namcap-tags +++ b/namcap-tags @@ -101,6 +101,8 @@ depends-by-namcap-sight depends=(%s) :: Depends as namcap sees them: depends=(%s dconf-needed-for-glib-schemas :: needed for glib schemas glib2-needed-for-gio-modules :: needed for GIO modules hicolor-icon-theme-needed-for-hicolor-dir :: needed for hicolor theme hierarchy +shared-mime-info-needed :: needed for update-mime-database +desktop-file-utils-needed :: needed for update-desktop-database kdebase-runtime-needed %s :: needed for programs %s java-runtime-needed %s :: found class files %s libraries-needed %s %s :: libraries %s needed in files %s
There are two missing tags that are needed in rules added (back) in commit e385ac93a354 (Restore and refactor accidentally removed tests). Add back the missing tags. Signed-off-by: Michael Straube <michael.straube@posteo.de> --- namcap-tags | 2 ++ 1 file changed, 2 insertions(+)