From patchwork Wed Aug 1 16:31:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: juergen@hoetzel.info X-Patchwork-Id: 713 Return-Path: Delivered-To: patchwork@archlinux.org Received: from apollo.archlinux.org (localhost [127.0.0.1]) by apollo.archlinux.org (Postfix) with ESMTP id 5BE2B5E0EC31 for ; Wed, 1 Aug 2018 16:31:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on apollo X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=DKIM_SIGNED=0.1, MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,T_DKIM_INVALID=1 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-BL-Results: [127.0.9.2] [127.0.0.11] Received: from orion.archlinux.org (orion.archlinux.org [IPv6:2a01:4f8:160:6087::1]) by apollo.archlinux.org (Postfix) with ESMTPS for ; Wed, 1 Aug 2018 16:31:50 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 16408C8315C87; Wed, 1 Aug 2018 16:31:49 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [IPv6:2a01:4f8:160:3033::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS; Wed, 1 Aug 2018 16:31:49 +0000 (UTC) Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id EF6FA2A645; Wed, 1 Aug 2018 16:31:48 +0000 (UTC) Authentication-Results: luna.archlinux.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=hoetzel-info.20150623.gappssmtp.com header.i=@hoetzel-info.20150623.gappssmtp.com header.b=NpnV6B/r Received: from luna.archlinux.org (luna.archlinux.org [127.0.0.1]) by luna.archlinux.org (Postfix) with ESMTP id 17D8E2A640 for ; Wed, 1 Aug 2018 16:31:47 +0000 (UTC) Received: from orion.archlinux.org (orion.archlinux.org [88.198.91.70]) by luna.archlinux.org (Postfix) with ESMTPS for ; Wed, 1 Aug 2018 16:31:47 +0000 (UTC) Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 345B5C8315C80 for ; Wed, 1 Aug 2018 16:31:46 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by orion.archlinux.org (Postfix) with ESMTPS for ; Wed, 1 Aug 2018 16:31:46 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id h15-v6so20716129wrs.7 for ; Wed, 01 Aug 2018 09:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hoetzel-info.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=NBax48ZHRDtQqVjOT9Bj1EaHjwOHoDKLn/TP0jhHM3I=; b=NpnV6B/rWxlp0oBaLNN4Lgydo3vq6rC54wIg8jCcDp3FeLWgq6boByZZlPLi7J8o7T bUoL/jG7OLYXwnDI+evmQUMHlLHmjov2P4RUB0gxEQwBbqmxuXEdOJu2pMM83KzlVcow Phwjq7RRHsNaHiM/AXJUgFNORVXR7H5mfRVCTyFT69jjqG05Cz4YcrM5reCFLlso2NF2 FCZLs789HGPZwRgZMLpFs51SdufTC0QZtKN/OENjmEq9vjkveNgduQ2Z5dO3QUhn2vgv iPULs41xmIA1gIcFlUMKaqqP3/bLRLwP+ikUZBK7Z7CzRU4dPnD7HUhOlFVe+Tj1FgLC 2y8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NBax48ZHRDtQqVjOT9Bj1EaHjwOHoDKLn/TP0jhHM3I=; b=uggJ/EuDKOKOH8HNI8c1810z0SiDdbkZasrPqFWknzcR+oXHgSz1silxjFzwvNFyan 04Og86vCJ78R+2EHInc+t5kCbtk83nvZkiHRbJdlZ3Dm3SijW6iBuH5KcqNuYfs182Qp b6v8m40Eejd3Fs6875OAd5iR5gvS1RKVf4/LbVdd60L0KOysjsHbgBetoUgcx4bzIyeR 4TRKr1DdmfO+wMIrsTUV+d1KRADJD/02D4p25Nn26dqhoNstIs3v6yKo4Qx5IcO5n5Gi MObTC1BkK0FVHMCHhKfDTpCznmaI2s/FccW+3dS83Z8R7l9Z2VNkXJvsufoCCaRp9KJj cZaQ== X-Gm-Message-State: AOUpUlFlDThNuxZLYibxr8BL/BHSiNSgkbM9svlszv6NeweHjvkEOqOT sWqJr6PjbbT2fqLeo458OnNdklDn8EA= X-Google-Smtp-Source: AAOMgpfJ+F50TQa2/vJzs/7835ksNiDlgRQdJi/FngujCO4F0vmPMk93xG/FPUqiGzmAFFWB0CQNuw== X-Received: by 2002:adf:8806:: with SMTP id d6-v6mr23861000wrd.41.1533141105223; Wed, 01 Aug 2018 09:31:45 -0700 (PDT) Received: from pidsley.fritz.box (dslb-188-106-126-236.188.106.pools.vodafone-ip.de. [188.106.126.236]) by smtp.gmail.com with ESMTPSA id g17-v6sm6185486wmh.19.2018.08.01.09.31.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Aug 2018 09:31:44 -0700 (PDT) From: To: pacman-dev@archlinux.org Date: Wed, 1 Aug 2018 18:31:30 +0200 Message-Id: <20180801163130.31518-1-juergen@hoetzel.info> X-Mailer: git-send-email 2.18.0 Subject: [pacman-dev] [PATCH] makechrootpkg: handle errors when copying packages into chroot X-BeenThere: pacman-dev@archlinux.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion list for pacman development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Discussion list for pacman development Cc: Juergen Hoetzel Errors-To: pacman-dev-bounces@archlinux.org Sender: "pacman-dev" From: Juergen Hoetzel Prevents consequential build errors. Signed-off-by: Juergen Hoetzel --- makechrootpkg.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/makechrootpkg.in b/makechrootpkg.in index d81be84..419e495 100644 --- a/makechrootpkg.in +++ b/makechrootpkg.in @@ -145,8 +145,10 @@ install_packages() { local ret pkgnames=("${install_pkgs[@]##*/}") - - cp -- "${install_pkgs[@]}" "$copydir/root/" + if ! cp -- "${install_pkgs[@]}" "$copydir/root/"; then + error "Cannot copy packages" + return 1 + fi arch-nspawn "$copydir" "${bindmounts_ro[@]}" "${bindmounts_rw[@]}" \ pacman -U --noconfirm -- "${pkgnames[@]/#//root/}" ret=$?