[dbscripts,2/2] test: BUILDDIR must be owned by build user

Message ID 20180529000222.32587-2-eschwartz@archlinux.org
State Accepted, archived
Headers show
Series [dbscripts,1/2] pacman 5.1 compatibility | expand

Commit Message

Emil Velikov via arch-projects May 29, 2018, 12:02 a.m. UTC
pacman 5.1 enforces this restriction. OTOH it is a simpler setup to set
this as the user homedir directly in account creation (just like
makechrootpkg has always done) than to create an additional,
world-writable, directory.

Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
---
 test/Dockerfile | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Emil Velikov via arch-projects May 29, 2018, 12:06 a.m. UTC | #1
On 05/28/2018 08:02 PM, Eli Schwartz wrote:
> pacman 5.1 enforces this restriction. OTOH it is a simpler setup to set
> this as the user homedir directly in account creation (just like
> makechrootpkg has always done) than to create an additional,
> world-writable, directory.
> 
> Signed-off-by: Eli Schwartz <eschwartz@archlinux.org>
> ---
>  test/Dockerfile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/test/Dockerfile b/test/Dockerfile
> index 3913f007..83c84499 100644
> --- a/test/Dockerfile
> +++ b/test/Dockerfile
> @@ -2,8 +2,7 @@ FROM archlinux/base
>  RUN pacman -Syu --noconfirm --needed sudo fakeroot awk subversion make kcov bash-bats gettext grep
>  RUN pacman-key --init
>  RUN echo '%wheel ALL=(ALL) NOPASSWD: ALL' > /etc/sudoers.d/wheel
> -RUN useradd -N -g users -G wheel -m tester
> -RUN install -d -m 1777 /build
> +RUN useradd -N -g users -G wheel -d /build -m tester
>  USER tester
>  RUN echo -e "\
>  Key-Type: RSA\n\

I cannot see why this does not work, but
https://travis-ci.org/archlinux/dbscripts/builds/384957987#L583 and
https://travis-ci.org/archlinux/dbscripts/builds/384957987#L597

Despite useradd being told to create the homedir "/build", it doesn't
seem to exist in the container.

Patch

diff --git a/test/Dockerfile b/test/Dockerfile
index 3913f007..83c84499 100644
--- a/test/Dockerfile
+++ b/test/Dockerfile
@@ -2,8 +2,7 @@  FROM archlinux/base
 RUN pacman -Syu --noconfirm --needed sudo fakeroot awk subversion make kcov bash-bats gettext grep
 RUN pacman-key --init
 RUN echo '%wheel ALL=(ALL) NOPASSWD: ALL' > /etc/sudoers.d/wheel
-RUN useradd -N -g users -G wheel -m tester
-RUN install -d -m 1777 /build
+RUN useradd -N -g users -G wheel -d /build -m tester
 USER tester
 RUN echo -e "\
 Key-Type: RSA\n\