[dbscripts,v2,1/3] test: common.bash:__getCheckSum: Don't rely on IFS

Message ID 20180223021541.15416-2-lukeshu@lukeshu.com
State Accepted
Headers show
Series Misc touchup | expand

Commit Message

Luke Shumaker Feb. 23, 2018, 2:15 a.m. UTC
From: Luke Shumaker <lukeshu@parabola.nu>

I managed to stumble across a bug in BATS where the run() function
screwed with the global IFS.  The bug has been fixed in git, but isn't
in a release yet.


Anyway, this bug breaks __getCheckSum().  Fortunately, we have avoided
tripping it so far because luck has it that we never call
__getCheckSum() after run() in the same test.

So, there's nothing actually broken here, but it makes me nervous.  So
go ahead and modify __getCheckSum to not rely on IFS.

And, while we're at it: declare the result variable and set it as
separate commands.  Doing both in the same command masks the exit code
of the subshell expansion.  We don't explicitly check the exit code,
but BATS runs the test suite with `set -e`, so splitting it does mean
that BATS will now detect errors from sha1sum.  We don't really expect
that to happen, but if BATS will give us error checking on it for
free, why not?

 - commit message: Mention spliting declare/set into separate commands.
 test/lib/common.bash | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


diff --git a/test/lib/common.bash b/test/lib/common.bash
index 568a541..5411641 100644
--- a/test/lib/common.bash
+++ b/test/lib/common.bash
@@ -9,8 +9,9 @@  __updatePKGBUILD() {
 __getCheckSum() {
-	local result=($(sha1sum $1))
-	echo ${result[0]}
+	local result
+	result="$(sha1sum "$1")"
+	echo "${result%% *}"
 __buildPackage() {