diff mbox series

[devtools,08/13] makechrootpkg: Add a comment warning about a bug in "sudo -i"

Message ID 20170505224110.28990-9-lukeshu@parabola.nu
State Accepted
Headers show
Series More patches from Parabola's new version | expand

Commit Message

Luke Shumaker May 5, 2017, 10:41 p.m. UTC 
The bug isn't currently triggered, but I accidentally did trigger when I
was trying to modify the command a bit.  I figure a "caution" sign would be
helpful to any future developers.
---
 makechrootpkg.in | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/makechrootpkg.in b/makechrootpkg.in
index d922fa0..2a19dbb 100644
--- a/makechrootpkg.in
+++ b/makechrootpkg.in
@@ -241,6 +241,10 @@  EOF
 # so no global variables
 _chrootbuild() {
 	. /etc/profile
+	# Beware, there are some stupid arbitrary rules on how you can
+	# use "$" in arguments to commands with "sudo -i".  ${foo} or
+	# ${1} is OK, but $foo or $1 isn't.
+	# https://bugzilla.sudo.ws/show_bug.cgi?id=765
 	sudo -iu builduser bash -c 'cd /startdir; makepkg "$@"' -bash "$@"
 }