mbox series

[devtools,0/7] Backports from Parabola v20180103

Message ID 20180115165759.26127-1-lukeshu@lukeshu.com
Headers show
Series Backports from Parabola v20180103 | expand

Message

Luke Shumaker Jan. 15, 2018, 4:57 p.m. UTC
From: Luke Shumaker <lukeshu@parabola.nu>

These are the commits in Parabola's developer tools v20180103 that are
not in upstream devtools that I think are upstreamable.  There's no
real theme to them.  Some of theme have been seen on this mailing list
before.

(I appologize that I waited 2 weeks to send this; I didn't send it
right away, then I forgot.)

Eli Schwartz (2):
  makechrootpkg: Fix unconditionally running namcap
  makechrootpkg: Fix anti-pattern when checking for enabled features

Luke Shumaker (5):
  arch-nspawn: make sure that makepkg.conf is always parsed as text
  arch-nspawn: Remove pointless $(echo ...) subshell
  lib/common.sh: Adjust to work properly with `set -u`
  makechrootpkg: Adjust to work properly with `set -e`
  makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf

 arch-nspawn.in   | 4 ++--
 lib/common.sh    | 4 +++-
 makechrootpkg.in | 9 +++++----
 3 files changed, 10 insertions(+), 7 deletions(-)

Comments

Emil Velikov via arch-projects Jan. 20, 2018, 3:15 p.m. UTC | #1
On 2018-01-15 17:57, Luke Shumaker wrote:
> From: Luke Shumaker <lukeshu@parabola.nu>
> 
> These are the commits in Parabola's developer tools v20180103 that are
> not in upstream devtools that I think are upstreamable.  There's no
> real theme to them.  Some of theme have been seen on this mailing list
> before.
> 
> (I appologize that I waited 2 weeks to send this; I didn't send it
> right away, then I forgot.)
> 
> Eli Schwartz (2):
>   makechrootpkg: Fix unconditionally running namcap
>   makechrootpkg: Fix anti-pattern when checking for enabled features
> 
> Luke Shumaker (5):
>   arch-nspawn: make sure that makepkg.conf is always parsed as text
>   arch-nspawn: Remove pointless $(echo ...) subshell
>   lib/common.sh: Adjust to work properly with `set -u`
>   makechrootpkg: Adjust to work properly with `set -e`
>   makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf
> 
>  arch-nspawn.in   | 4 ++--
>  lib/common.sh    | 4 +++-
>  makechrootpkg.in | 9 +++++----
>  3 files changed, 10 insertions(+), 7 deletions(-)
> 

LGTM. I will wait few days more if someone else would like to review it
and then merge it.

Bartłomiej
Emil Velikov via arch-projects Jan. 21, 2018, 12:19 a.m. UTC | #2
On 01/20/2018 10:15 AM, Bartłomiej Piotrowski via arch-projects wrote:
> On 2018-01-15 17:57, Luke Shumaker wrote:
>> From: Luke Shumaker <lukeshu@parabola.nu>
>>
>> These are the commits in Parabola's developer tools v20180103 that are
>> not in upstream devtools that I think are upstreamable.  There's no
>> real theme to them.  Some of theme have been seen on this mailing list
>> before.
>>
>> (I appologize that I waited 2 weeks to send this; I didn't send it
>> right away, then I forgot.)
>>
>> Eli Schwartz (2):
>>   makechrootpkg: Fix unconditionally running namcap
>>   makechrootpkg: Fix anti-pattern when checking for enabled features
>>
>> Luke Shumaker (5):
>>   arch-nspawn: make sure that makepkg.conf is always parsed as text
>>   arch-nspawn: Remove pointless $(echo ...) subshell
>>   lib/common.sh: Adjust to work properly with `set -u`
>>   makechrootpkg: Adjust to work properly with `set -e`
>>   makechrootpkg: Put "keyserver-options auto-key-retrieve" in gpg.conf
>>
>>  arch-nspawn.in   | 4 ++--
>>  lib/common.sh    | 4 +++-
>>  makechrootpkg.in | 9 +++++----
>>  3 files changed, 10 insertions(+), 7 deletions(-)
>>
> 
> LGTM. I will wait few days more if someone else would like to review it
> and then merge it.

Does that include the gpg.conf patch? Because as I said, I'd rather we
just got rid of copying ~/.gnupg at all. ;)

Also I'm obviously biased in favor of my still-outstanding patches from
this patchset. ;)

https://patchwork.archlinux.org/project/arch-projects/list/?series=44