[7/6] Vim: Set vim filetype for PKGBUILD.vim files

Message ID 20190117034440.8786-1-polyzen@archlinux.org
State Rejected
Headers show
Series
  • Vim additions and cleanup
Related show

Commit Message

Daniel M. Capella Jan. 17, 2019, 3:44 a.m. UTC
Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
---
 src/vim/ftdetect/PKGBUILD.vim | 1 +
 1 file changed, 1 insertion(+)

Comments

Johannes Löthberg Jan. 17, 2019, 6:50 p.m. UTC | #1
Excerpts from Daniel M. Capella's message of January 17, 2019 4:44:
> Signed-off-by: Daniel M. Capella <polyzen@archlinux.org>
> ---
>  src/vim/ftdetect/PKGBUILD.vim | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vim/ftdetect/PKGBUILD.vim b/src/vim/ftdetect/PKGBUILD.vim
> index cc84ccb..48475b6 100644
> --- a/src/vim/ftdetect/PKGBUILD.vim
> +++ b/src/vim/ftdetect/PKGBUILD.vim
> @@ -1 +1,2 @@
>  au BufNewFile,BufRead PKGBUILD set filetype=PKGBUILD
> +au BufNewFile,BufRead PKGBUILD.vim set filetype=vim

I think I would rather prefer it if this was fixed in vim upstream 
instead, since it's something broken there and not in our configs, and 
it's definitely vim's domain to fix the ft for *.vim things.

I don't really have any actual strong feelings about this in 
particular though.

Overall patchset LGTM.

Patch

diff --git a/src/vim/ftdetect/PKGBUILD.vim b/src/vim/ftdetect/PKGBUILD.vim
index cc84ccb..48475b6 100644
--- a/src/vim/ftdetect/PKGBUILD.vim
+++ b/src/vim/ftdetect/PKGBUILD.vim
@@ -1 +1,2 @@ 
 au BufNewFile,BufRead PKGBUILD set filetype=PKGBUILD
+au BufNewFile,BufRead PKGBUILD.vim set filetype=vim