[namcap] tests: pacman 5.1
diff mbox

Message ID 20180702072734.17354-1-michael.straube@posteo.de
State Not Applicable
Headers show

Commit Message

Eli Schwartz via arch-projects July 2, 2018, 7:27 a.m. UTC
Signed-off-by: Michael Straube <michael.straube@posteo.de>
---
 Namcap/tests/package/test_sodepends.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eli Schwartz via arch-projects July 5, 2018, 8:25 p.m. UTC | #1
I dislike this profoundly, because it fixes nothing and just papers over
it for a short while.

It's not hard to check the filesystem to determine what
/usr/lib/libalpm.so resolves to, which would make the tests non-broken
forever instead of constantly needing to be updated and only ever
working on the same version of pacman that was installed at the time the
namcap developers wrote the test.

Patch
diff mbox

diff --git a/Namcap/tests/package/test_sodepends.py b/Namcap/tests/package/test_sodepends.py
index 3a3d7b6..4188c35 100644
--- a/Namcap/tests/package/test_sodepends.py
+++ b/Namcap/tests/package/test_sodepends.py
@@ -56,13 +56,13 @@  package() {
 				)
 		self.assertEqual(pkg.detected_deps['pacman'], [
 			('libraries-needed %s %s',
-			 (str(['usr/lib/libalpm.so.10']), str(["usr/bin/main"]))
+			 (str(['usr/lib/libalpm.so.11']), str(["usr/bin/main"]))
 			)]
 		)
 		e, w, i = Namcap.depends.analyze_depends(pkg)
 		self.assertEqual(e, [
 			('dependency-detected-not-included %s (%s)',
-				('pacman', "libraries ['usr/lib/libalpm.so.10'] needed in files ['usr/bin/main']"))
+				('pacman', "libraries ['usr/lib/libalpm.so.11'] needed in files ['usr/bin/main']"))
 		])
 		self.assertEqual(w, [])