Add missing instruction for testing aurweb with a sqlite database
diff mbox

Message ID 20180128214816.22457-1-baptiste@bitsofnetworks.org
State Not Applicable, archived
Headers show

Commit Message

Baptiste Jonglez Jan. 28, 2018, 9:48 p.m. UTC
From: Baptiste Jonglez <git@bitsofnetworks.org>

Also clarify what to change in the configuration.

Signed-off-by: Baptiste Jonglez <git@bitsofnetworks.org>
---
 TESTING | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Eli Schwartz Jan. 28, 2018, 9:55 p.m. UTC | #1
On 01/28/2018 04:48 PM, Baptiste Jonglez wrote:
> From: Baptiste Jonglez <git@bitsofnetworks.org>
> 
> Also clarify what to change in the configuration.
There is already another patch that does this in the pu branch,
submitted 3 weeks ago and merged on Friday.
Baptiste Jonglez Jan. 28, 2018, 10:05 p.m. UTC | #2
On 28-01-18, Eli Schwartz wrote:
> On 01/28/2018 04:48 PM, Baptiste Jonglez wrote:
> > From: Baptiste Jonglez <git@bitsofnetworks.org>
> > 
> > Also clarify what to change in the configuration.
> There is already another patch that does this in the pu branch,
> submitted 3 weeks ago and merged on Friday.

Good point, I hadn't seen that patch/branch.

Regarding the content of this patch, it simply mentions to edit "php.ini",
while it would be clearer to talk about /etc/php/php.ini (at least for the
TESTING doc).

Baptiste

Patch
diff mbox

diff --git a/TESTING b/TESTING
index d2c97d9..fca23d7 100644
--- a/TESTING
+++ b/TESTING
@@ -13,7 +13,9 @@  INSTALL.
 
     # pacman -S php php-sqlite sqlite
 
-3) Prepare the testing database:
+3) Uncomment "extension=pdo_sqlite" in /etc/php/php.ini
+
+4) Prepare the testing database:
 
     $ cd /path/to/aurweb/schema
     $ make
@@ -21,12 +23,12 @@  INSTALL.
     $ sqlite3 ../aurweb.sqlite3 < aur-schema-sqlite.sql
     $ sqlite3 ../aurweb.sqlite3 < out.sql
 
-4) Copy conf/config.proto to conf/config and adjust the configuration
+5) Copy conf/config.proto to conf/config and adjust the configuration
    (pay attention to disable_http_login, enable_maintenance and aur_location).
 
-   Be sure to change backend to sqlite and name to the file location of your
-   created test database.
+   Be sure to set "backend" to "sqlite" and "name" to the file location of your
+   created test database.  An absolute path is recommended.
 
-5) Run the PHP built-in web server:
+6) Run the PHP built-in web server:
 
    $ AUR_CONFIG='/path/to/aurweb/conf/config' php -S localhost:8080 -t /path/to/aurweb/web/html