[1/4] SSO: Explain the rationale behind prompt=login

Message ID 20200714133406.GA3451296@tsubame.mg0.fr
State New
Headers show
Series
  • [1/4] SSO: Explain the rationale behind prompt=login
Related show

Commit Message

Frédéric Mangano-Tarumi July 14, 2020, 1:34 p.m. UTC
We might reconsider it in the future.
---
 aurweb/routers/sso.py | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Lukas Fleischer July 14, 2020, 10:49 p.m. UTC | #1
On Tue, 14 Jul 2020 at 09:34:06, Frédéric Mangano-Tarumi wrote:
> We might reconsider it in the future.
> ---
>  aurweb/routers/sso.py | 7 +++++++
>  1 file changed, 7 insertions(+)

Queued all patches in this patch series in pu, thanks Frédéric!

Patch

diff --git a/aurweb/routers/sso.py b/aurweb/routers/sso.py
index d0802c34..e1ec7efe 100644
--- a/aurweb/routers/sso.py
+++ b/aurweb/routers/sso.py
@@ -28,6 +28,13 @@  oauth.register(
 
 @router.get("/sso/login")
 async def login(request: Request):
+    """
+    Redirect the user to the SSO provider’s login page.
+
+    We specify prompt=login to force the user to input their credentials even
+    if they’re already logged on the SSO. This is less practical, but given AUR
+    has the potential to impact many users, better safe than sorry.
+    """
     redirect_uri = aurweb.config.get("options", "aur_location") + "/sso/authenticate"
     return await oauth.sso.authorize_redirect(request, redirect_uri, prompt="login")