[pacman-dev,v2] meson: use 'pedantic' compiler warning level by default

Message ID 20200326210726.512657-1-anatol.pomozov@gmail.com
State Changes Requested
Headers show
Series
  • [pacman-dev,v2] meson: use 'pedantic' compiler warning level by default
Related show

Commit Message

Anatol Pomozov March 26, 2020, 9:07 p.m. UTC
This sets parity with the autotools version of the build that has
-pedantic flag enbled unconditionally.

Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Allan McRae March 27, 2020, 4:05 a.m. UTC | #1
On 27/3/20 7:07 am, Anatol Pomozov wrote:
> This sets parity with the autotools version of the build that has
> -pedantic flag enbled unconditionally.
> 
> Signed-off-by: Anatol Pomozov <anatol.pomozov@gmail.com>
> ---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meson.build b/meson.build
> index 572526b2..fc81fa27 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -7,6 +7,7 @@ project('pacman',
>            'prefix=/usr',
>            'sysconfdir=/etc',
>            'localstatedir=/var',
> +          'warning_level=3',
>          ],
>          meson_version : '>= 0.51')
>  
> 

As discussed on here and IRC, -Wextra brings many flags and that is a
moving target.

I thought -pedantic would just be added to:

meson.build:
if get_option('buildtype').startswith('debug')
  extra_cflags = [
  ...

Patch

diff --git a/meson.build b/meson.build
index 572526b2..fc81fa27 100644
--- a/meson.build
+++ b/meson.build
@@ -7,6 +7,7 @@  project('pacman',
           'prefix=/usr',
           'sysconfdir=/etc',
           'localstatedir=/var',
+          'warning_level=3',
         ],
         meson_version : '>= 0.51')