[pacman-dev] Translation issues

Message ID 6160853.lOV4Wx5bFT@g550jk
State New
Headers show
Series
  • [pacman-dev] Translation issues
Related show

Commit Message

Luca Weiss March 14, 2020, 11:13 a.m. UTC
Hello,
I've noticed that in the Esperanto the following message is printed in 
makepkg:

==> Ekante $s()...

(In English e.g. "Starting package()")

It looks like the translation uses $s instead of %s.
A similar issue is also present in the Danish translation for a different 
string. Someone with access to these languages on Transifex should fix that. 
Here are the changes that should be done:



Regards
Luca

Comments

Allan McRae March 17, 2020, 4:17 a.m. UTC | #1
On 14/3/20 9:13 pm, Luca Weiss wrote:
> Hello,
> I've noticed that in the Esperanto the following message is printed in 
> makepkg:
> 

I approved your request to join the Esperanto translation team.

> ==> Ekante $s()...
> 
> (In English e.g. "Starting package()")
> 
> It looks like the translation uses $s instead of %s.
> A similar issue is also present in the Danish translation for a different 
> string. Someone with access to these languages on Transifex should fix that. 
> Here are the changes that should be done:
> 
> diff --git a/scripts/po/da.po b/scripts/po/da.po
> index 799c7b5c..ba2695ac 100644
> --- a/scripts/po/da.po
> +++ b/scripts/po/da.po
> @@ -1615,7 +1615,7 @@ msgstr "%s-fil (%s) findes ikke eller er ikke en regulær 
> fil."
>  #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:61
>  #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:92
>  msgid "%s_%s should be an array"
> -msgstr "$s_%s burde være et matrix"
> +msgstr "%s_%s burde være et matrix"

What version are you using?   This string does not exist in pacman-5.2.x

>  #: scripts/libmakepkg/source.sh.in:40
>  msgid "Retrieving sources..."
> diff --git a/scripts/po/eo.po b/scripts/po/eo.po
> index 08c72c03..f20c894f 100644
> --- a/scripts/po/eo.po
> +++ b/scripts/po/eo.po
> @@ -108,7 +108,7 @@ msgstr "Malsukcesis fonti %s"
>  
>  #: scripts/makepkg.sh.in:446
>  msgid "Starting %s()..."
> -msgstr "Ekante $s()..."
> +msgstr "Ekante %s()..."
>  

Looks like this string was fixed a month ago too.

>  #: scripts/makepkg.sh.in:559
>  msgid "Library listed in %s is not required by any files: %s"
> 
> 
> Regards
> Luca
> .
>
Luca Weiss March 17, 2020, 1:53 p.m. UTC | #2
On March 17, 2020 5:17:18 AM GMT+01:00, Allan McRae <allan@archlinux.org> wrote:
>On 14/3/20 9:13 pm, Luca Weiss wrote:
>> Hello,
>> I've noticed that in the Esperanto the following message is printed
>in 
>> makepkg:
>> 
>
>I approved your request to join the Esperanto translation team.

Thanks!

>
>> ==> Ekante $s()...
>> 
>> (In English e.g. "Starting package()")
>> 
>> It looks like the translation uses $s instead of %s.
>> A similar issue is also present in the Danish translation for a
>different 
>> string. Someone with access to these languages on Transifex should
>fix that. 
>> Here are the changes that should be done:
>> 
>> diff --git a/scripts/po/da.po b/scripts/po/da.po
>> index 799c7b5c..ba2695ac 100644
>> --- a/scripts/po/da.po
>> +++ b/scripts/po/da.po
>> @@ -1615,7 +1615,7 @@ msgstr "%s-fil (%s) findes ikke eller er ikke
>en regulær 
>> fil."
>>  #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:61
>>  #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:92
>>  msgid "%s_%s should be an array"
>> -msgstr "$s_%s burde være et matrix"
>> +msgstr "%s_%s burde være et matrix"
>
>What version are you using?   This string does not exist in
>pacman-5.2.x
>

I noticed shortly after sending the email that I was looking at an old version of pacman I had checked out. Sorry.

>>  #: scripts/libmakepkg/source.sh.in:40
>>  msgid "Retrieving sources..."
>> diff --git a/scripts/po/eo.po b/scripts/po/eo.po
>> index 08c72c03..f20c894f 100644
>> --- a/scripts/po/eo.po
>> +++ b/scripts/po/eo.po
>> @@ -108,7 +108,7 @@ msgstr "Malsukcesis fonti %s"
>>  
>>  #: scripts/makepkg.sh.in:446
>>  msgid "Starting %s()..."
>> -msgstr "Ekante $s()..."
>> +msgstr "Ekante %s()..."
>>  
>
>Looks like this string was fixed a month ago too.

Great; but that fix is definitely not pulled into git yet as of today ;)
Thanks!
Luca

>
>>  #: scripts/makepkg.sh.in:559
>>  msgid "Library listed in %s is not required by any files: %s"
>> 
>> 
>> Regards
>> Luca
>> .
>>
Eli Schwartz March 17, 2020, 2:56 p.m. UTC | #3
On 3/17/20 9:53 AM, Luca Weiss wrote:
> On March 17, 2020 5:17:18 AM GMT+01:00, Allan McRae <allan@archlinux.org> wrote:
>> Looks like this string was fixed a month ago too.
> 
> Great; but that fix is definitely not pulled into git yet as of today ;)

Transifex updates are only checked into git right before a release, to
avoid senseless code churn.

Patch

diff --git a/scripts/po/da.po b/scripts/po/da.po
index 799c7b5c..ba2695ac 100644
--- a/scripts/po/da.po
+++ b/scripts/po/da.po
@@ -1615,7 +1615,7 @@  msgstr "%s-fil (%s) findes ikke eller er ikke en regulær 
fil."
 #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:61
 #: scripts/libmakepkg/lint_pkgbuild/variable.sh.in:92
 msgid "%s_%s should be an array"
-msgstr "$s_%s burde være et matrix"
+msgstr "%s_%s burde være et matrix"
 
 #: scripts/libmakepkg/source.sh.in:40
 msgid "Retrieving sources..."
diff --git a/scripts/po/eo.po b/scripts/po/eo.po
index 08c72c03..f20c894f 100644
--- a/scripts/po/eo.po
+++ b/scripts/po/eo.po
@@ -108,7 +108,7 @@  msgstr "Malsukcesis fonti %s"
 
 #: scripts/makepkg.sh.in:446
 msgid "Starting %s()..."
-msgstr "Ekante $s()..."
+msgstr "Ekante %s()..."
 
 #: scripts/makepkg.sh.in:559
 msgid "Library listed in %s is not required by any files: %s"